Chrome Skin

About: Chrome Skin
TssTss
edited January 2009 in Style Reviews
Neiimad, some things I noticed:

- When you close all tabs and leave just one, this last tab doesn't look right;
- Bookmarks toolbar is not skinned;

Also, are you thinking of changing the buttons to use those of Chrome?
«13456789

Comments

  • NeiimadNeiimad
    edited February 2009
    Hi, and thx to have created this discussion about my style.

    Posted By: Tss- When you close all tabs and leave just one, this last tab doesn't look right;
    I don't have this problem. I often do this, and there is no bad looking. Can you make a sreenshot ?
    (have you tested with a default profil ? (no extension, no style))
    Posted By: Tss- Bookmarks toolbar is not skinned
    - Also, are you thinking of changing the buttons to use those of Chrome
    Edit: Yes, and it's done.


    @Xren, if he reads this :
    Xren
    My experience with your style says that IF NavBar doesn't have any button (which is by default) - it's height is smaller than should be and there is a problem.
    In your screenshot you placed ALL NavBar to MenuBar and that is why its height is fine.
    It's fixed.
  • xrenxren
    edited January 2009
    Yep, I read this :) Great!
    I guess you should try to fix issue with Faviconize Tab extension now (since it is very popular) and then MBLUE styles. If I find solution myself - I'll post the fix, but I think you'll make it faster than me :)
  • qwertzqwertz
    Thanks again Neiimad for this great skin. After 1 day using it, the problem I found is the close tab button hover. The button moves when hovered or pressed, which just isn't right.

    As for buttons, I didn't have time to come up with something myself, but these http://userstyles.org/styles/5317 seem to work for now, I only use back/forward/refresh though.
  • NeiimadNeiimad
    edited January 2009
    "Faviconize Tab" extension is now supported.



    Qwertz, There is no problem with the tab close button, it's made like it :
    - normal : vertical centered
    - hover : margin-top : 1px
    - active : margin-top : 2px
    (and directly in the list-style-image)
  • qwertzqwertz
    My bad, should have checked the image more closely. I just was confused, because the coordinates seemed correct.
  • TssTss
    edited January 2009
    About the tab glitch:
    I was using FF3.1b2, I've tried it in FF3.0.5 and works fine, so maybe it´s not urgent.
    Here´s a screenshot: http://img141.imageshack.us/my.php?image=1crux3.png
    It happens using a clean profile, so I don´t think it is some compatibility issue.

    About using Firefox or Chrome's buttons:
    Maybe a second style just for that... I think a lot of people would like this.
  • xrenxren
    So, The problem is the following (see pic):
    Image Hosted by ImageShack.us


    And I found a peace of code that is responsible for that:

    toolbox#navigator-toolbox toolbarbutton {
    height: 26px !important;
    margin-top: 2px !important; <<<<<<<<<<<< This is the problem; If you make
    margin-top: 0 !important; <<<<<<<<<<<<<< Then there is no problem with MBLUE's styles but all buttons are displaced by 2px UP and are not centered anymore.
  • NeiimadNeiimad
    edited January 2009
    For the FF 3.1b2 problem, I don't know what does this trouble, but it came from the close button. I don't have this version to check if the implementation (class, type, properties) of this button may be different...



    For the second screenshot & code
    is this mine ? And think to give me the MBLUE userstyle url and i'll see that to fix as possible.




    About the buttons :

    The main menu buttons are ok (look like GC buttons).

    I'm on the back/forward buttons now (i don't know if the style i wrote has too many characters or not to put more base64 code).
  • xrenxren
    I don't think you have to you base64 at all in order to fix issue with MBLUE styles (http://userstyles.org/styles/8620). I think you just have to adjust margins accordingly, so they don't affect that small black triangle.
  • ChoGGiChoGGi
    i made a style with chrome icons for ff if anyone wants it
    chrome icons
  • NeiimadNeiimad
    edited January 2009
    Xren, i was answering to you about buttons backgrounds, that's why i spoke about base64 ^^

    Thx for the url of userstyle.



    ChoGGi, i tested your buttons, but in fact they are not looking as they should. They are nice, but not appropriated to my skin.
    Not good looking, too tall, plus minor defaults...

    Image Hosted by ImageShack.us
    image

    I'll make them ;)
  • ChoGGiChoGGi
    yeah they are a bit big :)
    ChoGGi, i tested your buttons, but in fact they are not looking as they should. They are nice, but not appropriated to my skin.
    Not good looking, too tall, plus minor defaults...
    im guessing your using a style with background: to change the images instead of list-style-image: / -moz-image-region:
  • NeiimadNeiimad
    edited January 2009
    I don't have skinned the navigation button yet, but a background has been put to the stop+reload button (list-style-image still is here) ;)

    All right, navigation buttons are skinned.
  • xrenxren
    There is a problem with FullScreen Mode.....
  • NeiimadNeiimad
    edited January 2009
    Yes.

    Because to have TAB > TOOLBOX, toolbox has a margin from top to be under the tabs.
    It results that when tabs desappears in fullscreen mode, the toolbox rest visible...

    The fix i put is that i made the tabbrowser always visible...
  • qwertzqwertz
    Posted By: NeiimadI don't have skinned the navigation button yet, but a background has been put to the stop+reload button (list-style-image still is here) ;)

    All right, navigation buttons are skinned.
    Damn, you're fast, great work :)
  • NeiimadNeiimad
    i was completely on the skin for many days ;)
  • TssTss
    That issue with the last tab in FF3.1b2 is gone with the last update. Thank you!
  • NeiimadNeiimad
    You're welcome ;)
  • xrenxren
    The problem is on the pic:
    Image Hosted by ImageShack.us

    The New-Tab-Button image is displaced by 2-4 pixels.
  • xrenxren
    Oh! by the way - google chrome has different reload button:

    Image Hosted by ImageShack.us
    image
  • NeiimadNeiimad
    I see the first problem on win XP (i have worked on vista since). I'll fix it.

    For the reload button,, i know that it's different, but i wanted it to be fixed to the left of urlbar. But that's right the icon is not the same.
    Thanks for the screenshot, so, i'll make the background of home icone too ;)
  • xrenxren
    I've got a problem with stop/reload button
    Image Hosted by ImageShack.us
    image
  • NeiimadNeiimad
    edited February 2009
    Yes, i saw this. Now it's ok. (on XP), reload/stop&home buttons too.
  • xrenxren
    Hmmm..... New version of New-Tab-Button addon breaks the style :(((
  • NeiimadNeiimad
    edited February 2009
    Oh, right ? It's good on my FF (3.0.5, XP). Can you describe / screenshot the problem, Xren ?
  • xrenxren
    Steps to reproduce "the problem":
    1. Update your Firefox addons.
    2. Restart Firefox and you will see this:
    Image Hosted by ImageShack.us
  • NeiimadNeiimad
    edited February 2009
    Hmph ! I did not understand what you say the first time ! (i thought you spoke about my new code version skinning NTOTR).
    Okay, i'll see to fix it. (i hope they won't change their classes every versions... ;) )

    It's ok now. Thx to you another time :)
  • xrenxren
    edited February 2009
    Also it seems to me that cross image inside STOP button is NOT centered...
  • NeiimadNeiimad
    edited February 2009
    That's true. I was on something else. I do it.


    Done.
Sign In or Register to comment.