Need feedback: error prompts

JasonBarnabeJasonBarnabe
edited February 2007 in Stylish
When a style is installed from a site and the user doesn't change it, do you think it's useful to prompt the user about errors in the style? The current version does, but I'm thinking I'm going to remove it in this one case. Just because a style has errors doesn't mean it doesn't work - sometimes it's even best practice to do things that would cause errors.

Comments

  • dougeeebeardougeeebear
    edited February 2007
    I think a user should ALWAYS be prompted about errors, no matter what.
    Otherwise how would they even know (and learn)?
    If a style containes errors but still works, the author must already know about it and should make note of it in the descripton to make the user aware.
    I also remember an instance where a style had to be corrected because of a missing bracket (typo).
  • JasonBarnabeJasonBarnabe
    Posted By: dougeeebearOtherwise how would they even know (and learn)?
    If the style contained a real error, they'd know because then the style wouldn't work.
    Posted By: dougeeebearI also remember an instance where a style had to be corrected because of a missing bracket (typo).
    I would agree with this reasoning, except the site now has safeguards to prevent styles that are cut off from being posted.

    Mostly I'm wanting to improve the cross-browser support of styles posted. If someone puts
    foo { -moz-column-count: 2 !important; column-count: 2 !important; }
    that really shouldn't be giving the user an error.
  • ValacarValacar
    I'd call it a "warning" if it works, but has errors. How about turning it off, but have some place to turn it back on? I think Stylish could use an options dialog, but otherwise you could just add it to about:config.
  • JasonBarnabeJasonBarnabe
    Calling it a "warning" (or more generally, softening the language) is a good idea in all cases. It's never something that has to be fixed.
  • WeishunWeishun
    I agree with Valacar; if you change it, there ought to be an option to re-enable.
  • JasonBarnabeJasonBarnabe
    You do realize I'm thinking about turning it off only from installs from site, right? Any time you write your own or customize before saving, you'd definitely always get the prompt.
  • WeishunWeishun
    Posted By: Jason Barnabe (np)You do realize I'm thinking about turning it off only from installs from site, right?
    I didn't and I'm sure it'd be less confusing to the....ummm, "technology challenged" who are just installing the style to use as the author intended but displaying the errors can, on occasion, make life a bit simpler for those who may be installing it for other reasons. Yes, I realize, now, that editing the style would cause any errors to be displayed but having them displayed, in the first place, gives you an idea where you ought to start, sometimes. IMNSHO, having the errors display is a "feature"; not a "bug". 8-þ
Sign In or Register to comment.