Stylish 1.0.8 beta

JasonBarnabeJasonBarnabe
edited December 2009 in Stylish
Available here
  • Right-click a group in the add-ons dialog lets you enable, disable, find updates, or uninstall entire group
  • Add-ons dialog no longer shows Stylish icon on Mac
  • If you have a style for url-prefix(http://), it will no longer show up in all mange dialog search results
  • Styling a page with spaces in it works properly
  • Update to Japanese locale
  • Added Hebrew locale
Only en-US currently works...

Comments

  • makondomakondo
    edited December 2009
    Thanks for the update and adding enable/disable a group! Thank you!

    Forgot one more thing (you promised Smile) - renaming a tag changes tag for all styles in that group. Example: a tag 'sites' has 4 styles with that tag (sites). I rename it to Sites and all 4 styles under the old 'sites' are changed to Sites. I think you get it, right?
  • makondomakondo
    Jason,
    would it be possible for you to make it so that when styles are re-enabled, only the ones that have been enabled originally are enable again? As is now, let's say i have 4 styles in a group. 2 disabled, 2 enabled. I disable the group and then enable it: all 4 get enabled. It would make more sense if styles would returned to their original state.
    TIA!
  • DMCrimsonDMCrimson
    heads up np:) I've decided to change the contents of manage-addons-mac.css from: 
    #userstyles-view { 
	list-style-image: none !important;
}
    to 
    #viewGroup #userstyles-view {
	list-style-image: url('chrome://stylish/skin/s2-32.png');
}
#copy-style-info, #new-style {
	list-style-image: none !important;
}

#styles {
	overflow-x: auto;
	background-color: -moz-field;
	color: -moz-fieldtext;
	border: 2px solid;
	-moz-border-top-colors: ThreeDShadow ThreeDDarkShadow;
	-moz-border-right-colors: ThreeDHighlight ThreeDLightShadow;
	-moz-border-bottom-colors: ThreeDHighlight ThreeDLightShadow;
	-moz-border-left-colors: ThreeDShadow ThreeDDarkShadow;
}
#styles richlistitem {
	-moz-binding: url('chrome://stylish/content/style.xbl#regular');
}
#styles richlistitem *[anonid="tags"], #styles richlistitem:not([update="true"]) *[anonid="actions"], #styles richlistitem *[anonid="type"], #styles richlistitem[is-disabled="true"] *[anonid="disable"], #styles richlistitem:not([is-disabled="true"]) *[anonid="enable"] {
	display: none;
}
#styles richlistitem[selected="true"]:not([update="true"]):not([tags=""]) *[anonid="tags"] {
	display: -moz-box;
}
#styles richlistitem[selected="true"] *[anonid="actions"] {
	display: -moz-deck;
}
#styles richlistitem[filter-match="false"] {
	display: none;
}
#styles:focus richlistitem[selected="true"] {
	background-color: highlight;
	color: highlighttext;
	background-image: url(chrome://mozapps/skin/extensions/itemEnabledFader.png);
}
style-container {
	-moz-binding: url('chrome://stylish/content/style.xbl#container');
}
#userstyles-heading {
	-moz-box-align: center;
}
#no-styles-note {
	margin-top: 3em;
	margin-left: 5em;
	margin-right: 5em;
}

    Why? to get the manager pane an icon in addons-manager:) Could you, per any chance, make the default behaviour to have the icons as is case on win/linux and add a preference to disable the icon?
  • JasonBarnabeJasonBarnabe
    New version is up at the same link.
    Posted By: makondorenaming a tag changes tag for all styles in that group
    Done.
    Posted By: makondowould it be possible for you to make it so that when styles are re-enabled, only the ones that have been enabled originally are enable again?
    I think that'd be too confusing... I'd expect them all to be enabled.
    Posted By: DMCrimsonCould you, per any chance, make the default behaviour to have the icons as is case on win/linux and add a preference to disable the icon?
    I don't want to mess with how Firefox displays thing by default.
  • makondomakondo
    Posted By: Jason Barnabe (np)
    Posted By: makondowould it be possible for you to make it so that when styles are re-enabled, only the ones that have been enabled originally are enable again?
    I think that'd be too confusing... I'd expect them all to be enabled.
    Hmm... maybe we're talking about different things here. Let's say i have 3 styles in one group and 2 of them are enabled. I disable the whole group and then i re-enable it. At this point, i want things to go back the way they were before fiddling with it, that is 2 enabled and 1 disabled. Having all of them enabled all of a sudden defeats the whole idea 'cause now i have to go back and disable the previously disabled style (if i wrote it down or have a very good memory 'cause most likely there'd be more than one disabled style).
  • makondomakondo
    Thanks for the update.! Changing tags on a click is awesome!
    Thank you!
  • JasonBarnabeJasonBarnabe
    Posted By: makondoHmm... maybe we're talking about different things here.
    No, I understand what you're saying and why you want it. It's just that having an item called "Enable" means to me that it'll enable all of them. If it were any other way, people would ask why Enable misses some items.
  • makondomakondo
    Well, you could call it Revert to the Previous State ... or just put that in a tooltip wink
    I guess, Enable and Revert serve diff. purpose. A group can be disabled for whatever reason (like day/night styles, for example) and it makes perfect sense to have it all enabled/disabled. Revert option is handy for conflicts checking - instead of disabling all styles, you can disable a certain group or group by group. In that case, reverting back to the previous state is the key.
  • AloisAlois
    I have this interesting problem that's been lingering for a while, and I'd put it down to using Firefox 3.6pre builds, or somesuch. Every time I open the Stylish context menu, I've got all the presently valid (disabled and enabled both) styles listed at the bottom-- twice. Once below a menu separator, and once above.

    The list above is an exact duplicate, at least to start: if I switch to a tab with a different site open, and hence a different list of valid styles, the new entries populate into the duplicate list (above the separator), and keep duplicating as I open and close the menu.

    Every time I re-open the context menu, I get a whole new set of entries for the present valid styles. And it keeps going until the context menu is taller than the screen-- and then keeps going and going until I restart Fox.

    This happens with and without Stylish-Custom enabled, and it's persisted into the 1.0.8 beta, so I'm posting here.
  • JasonBarnabeJasonBarnabe
    What platform, and do you see anything in the Error Console with javascript.options.showInConsole=true?
  • AloisAlois
    Posted By: Jason Barnabe (np)What platform, and do you see anything in the Error Console with javascript.options.showInConsole=true?
    Ubuntu Karmic amd64 (with a few Lucid bits-- mostly kernel and audio), Fox 3.6.2pre (Ubuntu Mozilla Daily Builds Team PPA). No console errors reported, even with .strict set to true.

    -- I *do* have javascript.options.jit.chrome set true, but I've already tried it both ways, with restarts in between.
  • AloisAlois
    Posted By: Jason Barnabe (np)What platform, and do you see anything in the Error Console with javascript.options.showInConsole=true?
    ...er... any other info I can provide to help track this down?
  • AloisAlois
    Jason, any help at all for the menu contents corruption? I don't even know where to begin to investigate this on my own.
  • AloisAlois
    Finally found this on my own. https://addons.mozilla.org/en-US/firefox/addon/8266 and Stylish are incompatible. I don't recall where the "known incompatible" list is (We do have one, right?), but it should probably go in.

    I've contacted the author to let him know about the breakage.
  • makondomakondo
    Are you using S-C? 'cause ChoGGi added his own icons there. That might be the reason.
  • ChoGGiChoGGi
    Posted By: makondoAre you using S-C? 'cause ChoGGi added his own icons there. That might be the reason.
    Posted By: AloisThis happens with and without Stylish-Custom enabled, and it's persisted into the 1.0.8 beta, so I'm posting here.
  • makondomakondo
    just kiddng...
  • JasonBarnabeJasonBarnabe
    Stylish 1.0.8 is out, btw.

    I figured out the problem of Stylish + Menu Icons Plus. Menu Icons Plus is adding class names to menu items, and Stylish isn't expecting it, so screws stuff up. If you go into Stylish's overlay.js, change the block for clearStyleMenuItems to this:

    menuItemClassesToClear: ["stylish-menuseparator", "style-menu-item", "no-style-menu-item"], clearStyleMenuItems: function(event) { var popup = event.target; for (var i = popup.childNodes.length - 1; i >= 0; i--) { for (var j = 0; j < stylishOverlay.menuItemClassesToClear.length; j++) { if (popup.childNodes[i].className.indexOf(stylishOverlay.menuItemClassesToClear[j]) != -1) { popup.removeChild(popup.childNodes[i]); break; } } } },
    I'll put this fix in the next version.
  • AloisAlois
    Thanks, np.
  • DMCrimsonDMCrimson
    Posted By: Jason Barnabe (np)I don't want to mess with how Firefox displays thing by default.
    Thus it's up to theme's developer to make it:) OTOH, that css I posted, didn't work out as a user style - any clues why? Luckily, you've laid stylis flat out, no need to unzip and rezip:)
Sign In or Register to comment.