I don't think (not always) in term of what I like or dislike but in term of what does bring more advantages than inconvenients in a better functionality-simplicity ratio. I was just giving an opinion, so you can have users and programmers feedback, as makondo suggested. I find your "Save & Close" button redundant (therefore not clean programming design), but I don't personaly have problem with it. If you like it and everebody does, that's fine for me. Good programmers often end up with less features as when they started ... wait and see ! You might still find that button ugly one day. :)
Other than, as I already said, I do like and use your extension.
Posted By: IzzyPartly agreed. To me, the "Save & Close" button absolutely makes sense: While working on a style, I might want to save the current state (since I solved one issue), but keep the window open (since I have to solve another) - instead of "Save" always closing the window and I have to permanently reopen it.
Press Escape on a Stylish window containing and unsaved style! It will ask you if you want to save it (great feature! :)) Press Enter, which means "OK", the default choice. That's it. The 'Save & Close' button is redundant as it doesn't add more functionality. It just sounds weird and catch the eye.
Guess you missed the point. What do I have to do if I want to save and not close if you remove that button? And what if I want to save and close? Depending on what the remaining save button will do, one of these action will require extra steps:
Esc + OK (to Save and Close) - while I'd rather feel unsafe pressing escape before saving, as most FF stuff would simply close (and many people are used to that).
Save + Cancel (to Save and Close)
Save + Open Manager + Search the List + Double-Click (to save and not close, if the Save button would close the window) - I'd kill the one forcing me to that again...
I guess at least makondo will agree, we need both buttons!
@ChoGGi: Please stop Agnelo asking for this, lay down the law... Maybe you send him some CSS code to "display:none" the button, which should make him happy as well - ah, I just see makondo already did
Posted By: makondoI believe, it was Izzy. I'm not too fond of 'Reset'. Cancel sounds perfectly fine to me - cancel my edits, don't know why it's so complicated all of a sudden. But if it only makes sense to me alone, then, by all means, call it whatever you wish.
Yes, it was me - and "whatever you wish" is to long to fit on the button.
Posted By: Izzy Guess you missed the point. What do I have to do if I want to saveand not close if you remove that button? And what if I want to save and close?
;-) You know, that's the thinking i was talking about up there ^. 'redundant (therefore not clean programming design)', 'a useless and disturbing button', 'ugly', 'unconventional' .... To me, it's all 'pre-programmed' thinking. 'It's ugly 'because it's unusual and i don't see it anywhere else'. I don't know how long you use this ext. but you probably didn't see the 'Un-Preview' button, did you? It was my favorite button! Because you don't see it anywhere else ;-) (BTW, CHoGGI, in memory of that funniest button i have ever seen, can you name the Undo button Un-Do? Thank you ). Don't know if Barbiegirl installed it yet, but you have to agree, Agnello, if 3 out of (the) 4 people using the ext. need the button, the button stays. And with the hiding code, everybody should be happy now. Peace! Now to the 'Cancel' button ....
Oh, and Izzy (CHoGGi too) - let's see, i have 109 styles published. About 60 of them are installed here. Since - i repeat - the site is 'buggy', i will have to install 109 styles of which 60 will be dupes (plus, some may be modified to work for me and differ from the published version - will have to go through each one with a fine comb) ... Or i have to manually put the url for 109 styles (wonder what Barbiegirl does for her over 300). Any other ideas?
ChoGGi, I think it would be great if on the first page at the top of this thread you post a nice big clear picture of the stylish custom editor. Even better if you could post a new one for each version, because I ( and others) may want to start from the beginning installing all the different versions to experience all the changes to decide which is their best choice. Thanks!
Barbiegirl, it does show the url, w/out a style. The problem is in update: if you click Page w/in a style' editor, it takes you to a New Style page instead of that style page. That's what we're talking about. Of course, you can copy/paste the url but the idea was (still is for me) to get to that page with the new, edited code already in the code box, replacing the old (published) one. I thought that's how it suppose to work but it doesn't for me. So, guys suggested it's 'cause i need to change the update url, etc. But thanks for taking the time anyway.
Posted By: makondoOf course, you can copy/paste the url but the idea was (still is for me) to get to that page with the new, edited code already in the code box, replacing the old (published) one.
Almost - but this would make no sense if it's not your style, and you just want to visit the styles page to e.g. leave a comment. I know, Agnelo would probably kill us all - but for this it would be nice to have a "Publish" button, if the site does support this...
Not quite. I'm talking about your own codes. You can't edit other people styles. So, if i edited my style, click Page, it'd be nice to have that code already be there just like new styles do. Publish will do for me too ;-)
So if I install some style from USO, since when I cannot edit it anymore? Locally I can adjust it, I just cannot post it. So I make some "improvements", and want to drop the author a note. Since it may be hard to find the style again on USO, I usually prefer to click that button to bring me to the correct page.
I understand your idea, and for sure I agree - but not to replace the current button. Button-mania! How about an option: "Clicking that option brings you... a) to the styles page, b) to the styles page for foreign styles, but to the edit page for your own, c) always ask, d) make a separate button for each task, e) f*ck that button - ahem, ok, hide it, kill it, make it go away"
Posted By: BarbiegirlChoGGi, I think it would be great if on the first page at the top of this thread you post a nice big clear picture of the stylish custom editor. Even better if you could post a new one for each version, because I ( and others) may want to start from the beginning installing all the different versions to experience all the changes to decide which is their best choice. Thanks!
i keep some screenshots on the guide, but i'm not making one for each version :) and this is my first attempt with javascript, so you'd probably want to stick with the newer version (less bugs)
Posted By: IzzyHow about an option: "Clicking that option brings you... a) to the styles page, b) to the styles page for foreign styles, but to the edit page for your own, c) always ask, d) make a separate button for each task, e) f*ck that button
a is left click, b is middle or right (right pastes the code middle doesn't), c is.. ask what?, d i'm not sure what you mean, and e i'd think would be kinda hard to do (possibly painful if there's broken glass)
@makondo thought of an idea that would take some time, but it wouldn't be all at once make a local copy of your styles page and bookmark it. when you want to edit a style open the bookmark and drag over a url
Posted By: IzzyHow about an option: "Clicking that option brings you... a) to the styles page, b) to the styles page for foreign styles, but to the edit page for your own, c) always ask, d) make a separate button for each task, e) f*ck that button
a is left click, b is middle or right (right pastes the code middle doesn't), c is.. ask what?, d i'm not sure what you mean, and e i'd think would be kinda hard to do (possibly painful if there's broken glass)
I meant to define the buttons behavior on the options page - so the user can decide what should happen when the button is clicked.
Izzy, and CHoGGi (don't know why it's so hard to understand all of a sudden) i'm not talking about any other situation but this (step by step - grab some coffee ;-)
1. Create a style. 2. Post it to USO. 3. Open it locally. 4. Edit it. 5. Click Page button in the editor. 6. it takes you (well, me) to a New Style page but should (or would be nice if it would) take you to that style page and have your new code already in the code box, replacing the old code (this may be optional).
The reason it doesn't work like that is - if i understand correctly - because while you posted the style, you didn't install it from the site, therefor there's no path to it. Right? If so, then i'm stuck with the old copy/paste way. No problem.
EDIT: Izzy, just re-read your post above. Forget that coffee, you had enough ;-) (a, b, c, d, .... are you kidding Agnelo?)
Stylish-Custom-0.4.7.xpi Edit: Cancel is now just a button, Save is now the menu ExternalEdit button now shows the file name of the editor made ExternalEdit try to open to file again if you press the external editor button twice Options: added a Browse button for the external editor added a button to remove old css files
Posted By: IzzyI meant to define the buttons behavior on the options page - so the user can decide what should happen when the button is clicked.
that probably would be a better idea, i'll see about it
Posted By: makondo(don't know why it's so hard to understand all of a sudden) i'm not talking about any other situation but this (step by step - grab some coffee ;-)
i knew what you meant, but other then adding the urls manually it isn't going to work (i might be able to do something if you use the page button for new styles, but it wouldn't help for old styles)
Now i'm confused. It works for the new styles, that is i create a style, click Page, it takes me to a New Style page with code already pasted there. The problem with 'updating' all my styles (read: installing them all over again from the site) is that it's buggy - USO doesn't recognize your style and installs a dupe! So, you have to either uninstall or rename your style first, otherwise, you will get a dupe. In my case, i will get 110 dupes to delete. Or i have to copy/paste urls ~100 times.... it's gonna be a long day.
.4.7: 1. Could you please switch Stylish Info and Options in the toolbar button dropdown menu? TIA! 2. What does it mean? - ' This will remove all opened files!' 3. 'How many milsecs to wait..." seems too long. Can't it be 'Delay for code refresh in the Stylish' because that's what it is about, isn't it? 4. Thank you! :)
EDIT: No, i don't like the new Save button. Save was a quick way to save before you goof it, when you're leaving for a short while, get interrupted by something.... Now i have to pause and think ... Click here, click there .... I do not like it, at all.
Or i have to copy/paste urls ~100 times.... it's gonna be a long day.
that's why i said just keep a list of urls handy for when you need it (you can drag a link to the update url textbox and it'll change the text to the link, then you can click page)
1. you want one above the other? what's wrong with the order now? 2. it checks the temp dir for Stylish-Custom*.css and deletes them (it doesn't know if you have the file opened in an editor) 3. it'll wait that amount of time then compare the last modified time to the original last modified time, if it's different then it'll update the code 4. your welcome
Click here, click there .... I do not like it, at all.
Sorry, CHoGGi, not sure what any of the above means :-) But about Options - i'm used to have Options/Prefs at the bottom of menus. All items above Options have to do with styles, so does Style Info. To me, it seems as the Options item interrupts the flow. The rest ... sorry, i don't get any of it. You can't drag anything in the update url textbox - the window disappears if you click outside of it. But then i'm not sure what you're talking about anyway. Remove is still a mystery to me. I know what the time thing does but what i'm saying, the naming of it is a bit long, so i suggested 'Delay the code refresh in the Stylish for ...' Just a thought. '... you can click and drag too' ? what and where?
I think, i'll go back a couple versions to when Save was Save. It's a royal pain now. I think we should have just Save, Undo (with 2 options) and Close.
The rest ... sorry, i don't get any of it. You can't drag anything in the update url textbox - the window disappears if you click outside of it. But then i'm not sure what you're talking about anyway.
if your firefox window isn't maximized (or the style dialog is in another monitor/screen) then you can drag a link over to the update url textbox and it'll stick the link in it (or copy/paste which is faster)
Remove is still a mystery to me.
when you press external edit it makes a Stylish-Custom*.css file in your temp dir if you close firefox (or it crashes) without closing the style dialog, then it'll stay there. remove deletes any file called Stylish-Custom*.css
I know what the time thing does but what i'm saying, the naming of it is a bit long, so i suggested 'Delay the code refresh in the Stylish for ...' Just a thought.
ah yes i see it makes the options a bit wide, how about "Delay between style updates"?
'... you can click and drag too' ? what and where? I think, i'll go back a couple versions to when Save was Save. It's a royal pain now. I think we should have just Save, Undo (with 2 options) and Close.
click and drag down on the save button release the mouse when it's over the save menuitem
Sorry for being dense.
:) i had a smile on my face when i posted 0.4.7, kinda surprised you didn't mention it in your first comment. Izzy had a good idea with the buttons, i was thinking a couple of predefined ones shouldn't be much trouble
My head is spinning. Opened a style + ext. editor. Edited the style, Save + Close. A dialog pops up 'The file C:\....Stylish-Custom.css' doesn't exist anymore. Keep this file in editor? Yes/No'. WTH? Can i have an option not to see any popups? especially the ones i don't understand ;-) I still don't get this new thing, i mean, i think! i understand what it does (not even quite sure about that) but when and why would i use it? I mean, if i close a style, it shouldn't close the external editor, right? Or does it?
EDIT: i just made some changes to a style, clicked Close and it closed w/out saving changes or asking me if i want to save them. That's what the tooltip says it will do. But the tooltip has a delay which is too long. I didn't care about this style, i didn't need to save the changes, however, when i clicked on that button, i expected it to close as is, with my changes saved. It seemed kind of natural. I did this a couple more times and i had the same reaction. Maybe you should name the button Exit? Because Exit applies that your changes will not be saved, you just exit (that's how it works in most applications - a popup will ask you if you want to save before exiting). As is now seems to be confusing, especially since we also have Undo options.
Opened a style + ext. editor. Edited the style, Save + Close. A dialog pops up 'The file C:\....Stylish-Custom.css' doesn't exist anymore. Keep this file in editor? Yes/No'. WTH? Can i have an option not to see any popups? especially the ones i don't understand ;-) I
sc will delete the file when you close the style dialog (was this a popup from firefox or your editor?)
still don't get this new thing, i mean, i think! i understand what it does (not even quite sure about that) but when and why would i use it? I mean, if i close a style, it shouldn't close the external editor, right? Or does it?
no it doesn't touch the editor
EDIT: i just made some changes to a style, clicked Close and it closed w/out saving changes or asking me if i want to save them. That's what the tooltip says it will do. But the tooltip has a delay which is too long. I didn't care about this style, i didn't need to save the changes, however, when i clicked on that button, i expected it to close as is, with my changes saved. It seemed kind of natural.
it does say close not save & close (it's still the cancel button. i just renamed it)
Stylish-Custom-0.4.8.xpi Edit: the bottom area can be customized missed a couple of places to close the css file (external edit) Options: added a tab to select bottom area buttons removed rightclick to reset Overlay: switched options/style info menuitems around
edit: forgot about tooltips for the bottom area options, they'll be in 0.4.9
Awesome, now everybody should be happy! I got 5 there (but with my style they're just plain text and don't take much room, however, is it possible to autofit in 2 rows? Like, if the window is re-sized, buttons flow into a second row). I still don't get that huge Remove bar. Remove what? In order to remove whatever it is it removes, do you have to go to the Options window and press that bar? Why is it so huge? Can't it be a regular button? 'Bottom Area' doesn't sound computer related ;-) Could you maybe rename to simply 'Buttons'?
however, is it possible to autofit in 2 rows? Like, if the window is re-sized, buttons flow into a second row
probably, i'll have to look around
I still don't get that huge Remove bar. Remove what? In order to remove whatever it is it removes, do you have to go to the Options window and press that bar? Why is it so huge? Can't it be a regular button?
it removes old css files that weren't deleted and if you happen to have some of those css files opened it'll still delete them, i've been thinking about making it do it when you start firefox instead it stretches to fit the width, guess i could make it not
'Bottom Area' doesn't sound computer related ;-) Could you maybe rename to simply 'Buttons'?
Geeze! I had to dig the thread from page 2! Sticky it, ChoGGi, will you? Any luck on wrapping the buttons area with window resize? Also, could you make it so that clicking any of the Undo buttons doesn't close the editor, please?
:-) You changed the Undo Last Save to Undo to the Last Save and - yeah, another oops! - i lost an edit. Clicked the button too fast, by habit... window closed, re-opened - what the hay?! nothin' there, all changes're gone! an hour i'll never get back! Now i need an Undo Last Save button ... quickly running out of space there though. The window is already stretching through my monitor ;-) I mean, the proper way to do it is probably preview/save and you shouldn't need to Undo Last Save then. Maybe you can write a code for those new/changed buttons to be red first but after a certain amount of times used (editor opened), go back to normal. How about a double-decker? 1. All Previews & Undos 2. All Saves & Close
heh i just noticed i'd forgotten to add the undo function and just had it on cancel
I mean, the proper way to do it is probably preview/save and you shouldn't need to Undo Last Save then. Maybe you can write a code for those new/changed buttons to be red first but after a certain amount of times used (editor opened), go back to normal.
NM, it was a joke. Even though i think it's possible: when you first update your installation, the new buttons you add or change (in the new update) stay big bold and red for ... 3 days, or 3 clicks, or ... til 6am of the next day ... (so that you don't accidentally click it like i did, w/out realizing it's a different button now 'cause Undo THE Last Save is not the same as Undo TO THE Last Save). A joke. I was kidding. :-)
Comments
I don't think (not always) in term of what I like or dislike but in term of what does bring more advantages than inconvenients in a better functionality-simplicity ratio. I was just giving an opinion, so you can have users and programmers feedback, as makondo suggested. I find your "Save & Close" button redundant (therefore not clean programming design), but I don't personaly have problem with it. If you like it and everebody does, that's fine for me. Good programmers often end up with less features as when they started ... wait and see ! You might still find that button ugly one day. :)
Other than, as I already said, I do like and use your extension.
@ChoGGi: Please stop Agnelo asking for this, lay down the law... Maybe you send him some CSS code to "display:none" the button, which should make him happy as well - ah, I just see makondo already did
You know, that's the thinking i was talking about up there ^. 'redundant (therefore not clean programming design)', 'a useless and disturbing button', 'ugly', 'unconventional' .... To me, it's all 'pre-programmed' thinking. 'It's ugly 'because it's unusual and i don't see it anywhere else'. I don't know how long you use this ext. but you probably didn't see the 'Un-Preview' button, did you? It was my favorite button! Because you don't see it anywhere else ;-) (BTW, CHoGGI, in memory of that funniest button i have ever seen, can you name the Undo button Un-Do? Thank you
Don't know if Barbiegirl installed it yet, but you have to agree, Agnello, if 3 out of (the) 4 people using the ext. need the button, the button stays. And with the hiding code, everybody should be happy now. Peace!
Now to the 'Cancel' button ....
Oh, and Izzy (CHoGGi too) - let's see, i have 109 styles published. About 60 of them are installed here. Since - i repeat - the site is 'buggy', i will have to install 109 styles of which 60 will be dupes (plus, some may be modified to work for me and differ from the published version - will have to go through each one with a fine comb) ... Or i have to manually put the url for 109 styles (wonder what Barbiegirl does for her over 300). Any other ideas?
@makondo i was thinking of changing it back to un-preview as it only shows up after you press preview so it shouldn't be confusing anyone lots of time :)
Even better if you could post a new one for each version, because I ( and others) may want to start from the beginning installing all the different versions to experience all the changes to decide which is their best choice. Thanks!
it does show the url, w/out a style. The problem is in update: if you click Page w/in a style' editor, it takes you to a New Style page instead of that style page. That's what we're talking about. Of course, you can copy/paste the url but the idea was (still is for me) to get to that page with the new, edited code already in the code box, replacing the old (published) one. I thought that's how it suppose to work but it doesn't for me. So, guys suggested it's 'cause i need to change the update url, etc. But thanks for taking the time anyway.
I understand your idea, and for sure I agree - but not to replace the current button. Button-mania!
and this is my first attempt with javascript, so you'd probably want to stick with the newer version (less bugs) a is left click, b is middle or right (right pastes the code middle doesn't), c is.. ask what?, d i'm not sure what you mean, and e i'd think would be kinda hard to do (possibly painful if there's broken glass)
@makondo
thought of an idea that would take some time, but it wouldn't be all at once
make a local copy of your styles page and bookmark it. when you want to edit a style open the bookmark and drag over a url
and CHoGGi
(don't know why it's so hard to understand all of a sudden) i'm not talking about any other situation but this (step by step - grab some coffee ;-)
1. Create a style.
2. Post it to USO.
3. Open it locally.
4. Edit it.
5. Click Page button in the editor.
6. it takes you (well, me) to a New Style page but should (or would be nice if it would) take you to that style page and have your new code already in the code box, replacing the old code (this may be optional).
The reason it doesn't work like that is - if i understand correctly - because while you posted the style, you didn't install it from the site, therefor there's no path to it. Right?
If so, then i'm stuck with the old copy/paste way. No problem.
EDIT:
Izzy, just re-read your post above. Forget that coffee, you had enough ;-) (a, b, c, d, .... are you kidding Agnelo?)
Edit:
Cancel is now just a button, Save is now the menu
ExternalEdit button now shows the file name of the editor
made ExternalEdit try to open to file again if you press the external editor button twice
Options:
added a Browse button for the external editor
added a button to remove old css files
that probably would be a better idea, i'll see about it i knew what you meant, but other then adding the urls manually it isn't going to work (i might be able to do something if you use the page button for new styles, but it wouldn't help for old styles)
The problem with 'updating' all my styles (read: installing them all over again from the site) is that it's buggy - USO doesn't recognize your style and installs a dupe! So, you have to either uninstall or rename your style first, otherwise, you will get a dupe. In my case, i will get 110 dupes to delete. Or i have to copy/paste urls ~100 times.... it's gonna be a long day.
.4.7:
1. Could you please switch Stylish Info and Options in the toolbar button dropdown menu? TIA!
2. What does it mean? - ' This will remove all opened files!'
3. 'How many milsecs to wait..." seems too long. Can't it be 'Delay for code refresh in the Stylish' because that's what it is about, isn't it?
4. Thank you! :)
EDIT:
No, i don't like the new Save button. Save was a quick way to save before you goof it, when you're leaving for a short while, get interrupted by something.... Now i have to pause and think ... Click here, click there .... I do not like it, at all.
1. you want one above the other? what's wrong with the order now?
2. it checks the temp dir for Stylish-Custom*.css and deletes them (it doesn't know if you have the file opened in an editor)
3. it'll wait that amount of time then compare the last modified time to the original last modified time, if it's different then it'll update the code
4. your welcome you can click and drag too
But about Options - i'm used to have Options/Prefs at the bottom of menus. All items above Options have to do with styles, so does Style Info. To me, it seems as the Options item interrupts the flow.
The rest ... sorry, i don't get any of it. You can't drag anything in the update url textbox - the window disappears if you click outside of it. But then i'm not sure what you're talking about anyway.
Remove is still a mystery to me.
I know what the time thing does but what i'm saying, the naming of it is a bit long, so i suggested 'Delay the code refresh in the Stylish for ...' Just a thought.
'... you can click and drag too' ? what and where?
I think, i'll go back a couple versions to when Save was Save. It's a royal pain now. I think we should have just Save, Undo (with 2 options) and Close.
Sorry for being dense.
if you close firefox (or it crashes) without closing the style dialog, then it'll stay there. remove deletes any file called Stylish-Custom*.css ah yes i see it makes the options a bit wide, how about "Delay between style updates"? click and drag down on the save button release the mouse when it's over the save menuitem :)
i had a smile on my face when i posted 0.4.7, kinda surprised you didn't mention it in your first comment. Izzy had a good idea with the buttons, i was thinking a couple of predefined ones shouldn't be much trouble
Opened a style + ext. editor. Edited the style, Save + Close. A dialog pops up 'The file C:\....Stylish-Custom.css' doesn't exist anymore. Keep this file in editor? Yes/No'. WTH? Can i have an option not to see any popups? especially the ones i don't understand ;-) I still don't get this new thing, i mean, i think! i understand what it does (not even quite sure about that) but when and why would i use it? I mean, if i close a style, it shouldn't close the external editor, right? Or does it?
EDIT: i just made some changes to a style, clicked Close and it closed w/out saving changes or asking me if i want to save them. That's what the tooltip says it will do. But the tooltip has a delay which is too long. I didn't care about this style, i didn't need to save the changes, however, when i clicked on that button, i expected it to close as is, with my changes saved. It seemed kind of natural.
I did this a couple more times and i had the same reaction. Maybe you should name the button Exit? Because Exit applies that your changes will not be saved, you just exit (that's how it works in most applications - a popup will ask you if you want to save before exiting). As is now seems to be confusing, especially since we also have Undo options.
Edit:
the bottom area can be customized
missed a couple of places to close the css file (external edit)
Options:
added a tab to select bottom area buttons
removed rightclick to reset
Overlay:
switched options/style info menuitems around
edit: forgot about tooltips for the bottom area options, they'll be in 0.4.9
I still don't get that huge Remove bar. Remove what? In order to remove whatever it is it removes, do you have to go to the Options window and press that bar? Why is it so huge? Can't it be a regular button?
'Bottom Area' doesn't sound computer related ;-) Could you maybe rename to simply 'Buttons'?
Thanks for moving Option item - feels right now!
it stretches to fit the width, guess i could make it not sure
no luck with wrapping, and oops
You changed the Undo Last Save to Undo to the Last Save and - yeah, another oops! - i lost an edit. Clicked the button too fast, by habit... window closed, re-opened - what the hay?! nothin' there, all changes're gone! an hour i'll never get back! Now i need an Undo Last Save button ... quickly running out of space there though. The window is already stretching through my monitor ;-) I mean, the proper way to do it is probably preview/save and you shouldn't need to Undo Last Save then. Maybe you can write a code for those new/changed buttons to be red first but after a certain amount of times used (editor opened), go back to normal.
How about a double-decker?
1. All Previews & Undos
2. All Saves & Close
Even though i think it's possible: when you first update your installation, the new buttons you add or change (in the new update) stay big bold and red for ... 3 days, or 3 clicks, or ... til 6am of the next day ... (so that you don't accidentally click it like i did, w/out realizing it's a different button now 'cause Undo THE Last Save is not the same as Undo TO THE Last Save).
A joke.
I was kidding.
:-)