Stylish-Custom

1111214161781

Comments

  • i basically have it working, just having an issue with something that i'm not sure what it is :)
    it can read the changed file and add the text, but it can't get the new file size or last modified time, so i can't change the buffer or see if it's been edited

    @makondo i think the idea is one less extension (i only have iat installed for stylish)
    2. seems like a good idea
  • Posted By: makondoRight. So... what am i missing again? Don't we have the 'external editor' button?
    I didn't say we don't and didn't ask for it. Please read my post again!

    The problem with using an external editor is that you can't preview, for one.
    I use an external editor and do preview all the time. That's actually the reason why I did lose my changes while accidentally pressing Escape, because in the external editor I am using, yo do press Escape to switch between editing mode and command line. At this moment, if the Stylish window still has the focus, it just got killed by Escape - that was before ChoGGi added the confirmation dialog.

    It's All Text! creates a temporary file and opens it in your external editor. When you save it there, you can see the changes in Stylish. It takes about one or two seconds to reflect the changes and the Stylish editing window blinks for a short time while doing that. Tha't what I see under Linux and Unix. I don't know how it behaves under Windows (but to be honest, I don't really care).
  • edited July 2009
    Phew! i don't remember being THAT confused for a while ;-)

    I was replying to:
    Posted By: AgneloIt would be more logical and more efficient to implement a function which opens an external editor - even if it already exists in other extensions.
    ... and, i guess, i misreading something.
    I use an ext. editor ... and just discovered that i need to actually save a change in there to show in the Stylish editor! Did not know that! BTW, i set IAT to refresh in 1 sec. and the change is instant here.
    Anyway, so what's all this about, ChoGGi? Are you trying to add the ext.editor w/out use of IAT?
  • @ ChoGGi

    hmmm ... Remember that I didn't ask for it! Don't mess up your extension because of me. :-)

    I was just trying to say that, rather than adding editing functions to the Stylish interface, implementing a call to an external editor would be a more logical enhancement for a Stylish Plus extension (in theory). However IAT provides already this feature and is well integrated in Stylish. But IAT is not limited to neither specialized on Stylish. That's why - in some way - this feature would make sense, even if it is not "needed" yet by anybody, except by people who would have a good reason not to use IAT.
  • Stylish-Custom-0.4.6.xpi
    Edit:
    changed cancel to be a menu (check the tooltips for info)
    added a button to use an external editor
    Options:
    added some options for the external editor

    @Agnelo it looks to me like you were the one asking for it or am i missing something?
    btw for "You could also enhance the 'search' in a 'search & replace'" what did you mean?

  • @Agnelo it looks to me like you were the one asking for it or am i missing something?
    If you separate this sentence from its context, you might indeed have missed my point.

    btw for "You could also enhance the 'search' in a 'search & replace'" what did you mean?
    I actually wanted to discourage you from doing that. I meant that adding a button to use an external editor would be more clever than trying to improve Stylish with enhanced editing features (like for example a 'search & replace'), because, unless you're willing to spend months or even years on it, you're not going to make a better editor out of the Stylish interface than many existing text editors out there. But I was not asking for it, simply giving an opinion. I already had a similar conversation with Jason - while looking for a way to use an external editor - and he advised me to use IAT.
  • If you separate this sentence from its context, you might indeed have missed my point.
    ah yes, and i even noticed that last time :)
    you're not going to make a better editor out of the Stylish interface than many existing text editors out there.
    i prefer using scite for editing styles, but that doesn't mean i can't add a few features for doing a quick style (search i use all the time, replace not so much)
  • i prefer using scite for editing styles, but that doesn't mean i can't add a few features for doing a quick style (search i use all the time, replace not so much)
    No, that doesn't mean that. And I like most of the features you added. I just wanted to warn you against the temptation of adding to many and suggested that if you intended to do so, a button to use an external editor would have been more efficient.
  • edited July 2009
    CHoGGi!
    Does your new Ext.Edit button means i don't need the IAT ext.?
    1. There's no 'Browse' button to set a path. Would be nice to have one.
    2. What the wait time for? Why would anybody want to wait to see the changes?
    3. Undo All Saves button - it just doesn't sound right. Maybe 'Undo All' or 'Undo All Changes' + there's a delay for the tooltip that is just a tad too long, IMO. I don't know if you set or or the system, probably the latter.
    4. The Page button:
    you know how USO is disconnected from the ext. and your styles? It doesn't recognize styles and their state and i never pay attention to those Install and Update buttons. If i change a style here, then go to update the code there and change it manually, the site will tell me there's an update! - it's the same style, damnit!!
    Anyway. Clicked the Page button after editing a (published) style. It took me to a New style page. When i went to the style's page, it had an Install button! Another words, your great buttons not gonna work unless np fixes his bugs.
    5. Options: i don't think you need anything there since Stylish doesn't have any of those options. Tools menuitem show/hide and info location can be moved to general.

    Thanks for the update!
  • 1. i'll add it to 0.4.7
    2. i was going to make it every 5 seconds then i figured someone was going to ask for a quicker time so yea
    3. Undo All Changes seems decent, and i don't set the tooltip timeout
    4. if you make a style and post it, you'll need to change the update url (that's what the page button uses)
    5. they are menuitems, so shouldn't they be under menuitems? (if you have some better suggestions for the tab names, i just picked enough to somewhat evenly separate them)
  • edited July 2009
    4. I don't get it. The style is posted a while ago. I edit it here, click Page and it opens a new style page. It should (and i thought that's how it was suppose to work) take me to that style page /edit. I'm doing it the old copy/paste way.
    5. Sorry, i didn't type the whole sentence ;-)
    I was thinking about those items that have Stylish/Stylish-Custom checkboxes: Tools Show/Hide and Style Info menuitem location (whatever that means. I think Style Info location would be enough). The rest doesn't exist in Stylish and therefore is not needed in S-C, IMO. What's Toggle Rules anyway? You can leave them there, if you want. I was thinking eliminate one tab, put them under General. The 'Text' tab ... maybe it should be 'Editor' instead or 'Stylish Editor' since there's 'External Editor' right next to it?
    Also, it says: Reset an option by right-clicking a radio ... Why Rclicking? It works on Lclick as well.

    All this is just my thoughts. I'm not a programmer and can't care less if it's not 'how it's done' simply because it's not always done right in the first place, from my, a user, sense and logic view. We all have an application or two (if not the whole system) that definitely can use a major improvement from users point of view and yet somehow developers are too often miss it somehow. It almost seems as if they don't use what they develop.
    I hope others will post their suggestions. After all, i don't think i'm the only one using it ... or my suggestions are so perfect nobody has a thing to add! ;-)
  • 4. if you install a style it adds the update url for you, if you create a new style it won't have an update url (it doesn't matter if you post it to userstyles it still needs an update url)
    5. toggle rules is for disable/enable all styles.
    you can add them to the stylish menu, that's why there's an option to do so (say someone doesn't want another toolbar button, they can add everything to stylish and remove the sc button)
    lclick doesn't reset an option it selects an option

    don't forget different people use things differently, to one person it's retarded and to another it's perfect
  • edited July 2009
    Not bad ! I was wondering what you would do with the IAT button. You did well. Now you can have two different external editors by setting one in there and another one in IAT. That's indeed an improvment.

    A few remarks :

    1) You should make the default editor depend on the Operating system since "C:\windows\notepad.exe" only makes sense on Windows.
    There isn't a GUI text editor installed by default on Linux and Unix like OS, but most Gnome users should have "gedit". On Mac OS X, it should be TextEdit, but it doesn't open. I wonder why. TextMate doesn't open either. Maybe a security issue (?) The absolute path is important and varies on the different OS. I would suggest something like the following code (these are the correct paths) :


    var extEditor
    var nua = navigator.userAgent.toLowerCase();

    if (0 <= nua.indexOf("linux")) {
    extEditor='/usr/bin/gedit';
    } else if (0 <= nua.indexOf("freebsd")) {
    extEditor='/usr/local/bin/gedit';
    } else if (0 <= nua.indexOf("openbsd")) {
    extEditor='/usr/local/bin/gedit';
    } else if (0 <= nua.indexOf("netbsd")) {
    extEditor='/usr/pkg/bin/gedit';
    } else if (0 <= nua.indexOf("dragonflybsd")) {
    extEditor='/usr/pkg/bin/gedit';
    } else if (0 <= nua.indexOf("mac os x")) {
    extEditor='/Applications/TextEdit.app';
    } else {
    extEditor='C:\windows\notepad.exe';
    }

    I'm missing an entry for openSolaris (I don't have it).

    2) What about making the button label text reflect the name of the choosen external editor (without path and extension) ?

    3) The drop down menu under the cancel button is unconventional and, I should say, rather annoying. Let it just be a 'cancel' button.
  • Posted By: Agnelo1) You should make the default editor depend on the Operating system since "C:\windows\notepad.exe" only makes sense on Windows.
    You mean notepad.exe could really make sense? I'd rather say the only sense it makes is to serve as a syntax example. I see no improvement using notepad.exe instead of the internal editor Whistle
  • CHoGGi, i agree with ^ 3). It's kinda annoying. The 'Cancel' button didn't and doesn't make sense to me anyway. 'Cancel' what? Am i closing the window? There's Save and Close which is the same as Close. Or, if you don't want to Save ... then you can use Undo with 2 options.... but then we still need a Close button?
    Maybe there should be:
    Save and Close (saves the current state and closes the window)
    Undo (changes after the last save)
    Cancel and Close (discard all changes and close window).
    Posted By: Agnelo... Now you can have two different external editors...
    Not really. You still can use only one at a time unless you want to go back to options and reset it to open another editor... for whatever reason. I thought the idea was to eliminate the need for another ext. all together. I guess not.
  • Hi, Izzy!
    I think the idea was (see my post above) to eliminate the need for It'sAllText! and set an external editor from Stylish itself. Which is fine by me (especially after CHoGGi adds the browse function to ease it up a bit). I can't see how having 2 buttons to do the same thing is beneficial either. After all, you set it and forget (preferable situation), no?

    BTW, Good Morning!
  • edited July 2009
    Posted By: ChoGGiif you install a style it adds the update url for you, if you create a new style it won't have an update url (it doesn't matter if you post it to userstyles it still needs an update url)
    That's the problem. I have about 100 styles posted and have to install them all (or edit the path manually) to set the path so that the site will show proper buttons? Don't think so. I have only 1-3? styles by someone else and they're good as is, no updates needed. So, i don't use Update at all. But at least i now understand - i think - why i see different buttons on styles pages, thanks!
    Posted By: ChoGGi... toggle rules is for disable/enable all styles...
    Don't be surprised if i'll ask you about this again, a third, forth ... time ;-) Toggle Rules doesn't tell me much and i easily forget what it's about, sorry.
    Posted By: ChoGGilclick doesn't reset an option it selects an option
    Sorry, not sure what this means. Isn't selecting an option the same as resetting it? I Lclick to show the icon in the statusbar and there it is. I Lclick not to show - there it goes.
  • Posted By: Izzy
    You mean notepad.exe could really make sense?
    I mean Windows doesn't make sense.
    Posted By: makondo
    Maybe there should be:
    Save and Close (saves the current state and closes the window)
    Undo (changes after the last save)
    Cancel and Close (discard all changes and close window).
    'Save' and 'Cancel' is all you need in a clean design.
    The 'Save & Close' button is absurd.
    If you want an 'undo' feature, you should make an 'undo' button. However that feature isn't very useful and looks rather 'stuffy' here (my opinion).
  • Posted By: makondoMaybe there should be:
    Save and Close (saves the current state and closes the window)
    Undo (changes after the last save)
    Cancel and Close (discard all changes and close window).
    Agree concerning the functionality. But then "Cancel" is misleading (Cancel what?) - other apps name it something like "Reload". And before you protest: In our context this could also be misleading (one may think of reloading the page), so I'd suggest "Reset" (as long as noone thinks it would press the "Windows repair button" and reboot the machine LOL)
    I think the idea was (see my post above) to eliminate the need for It'sAllText! and set an external editor from Stylish itself.
    Yes, I got that. I just was playing with words. I understand that ChoGGi chose some app available on every (Windows) machine - it's just that nobody would really consider notepad.exe being an improvement here.
    BTW, Good Morning!
    Yepp, agreed Peace
    That's the problem. I have about 100 styles posted and have to install them all (or edit the path manually) to set the path so that the site will show proper buttons?
    You just have to do this once for every style published on USO, so the URLs match. When you publish the next update, USO will offer you the "Update" button (yes, you're right: It does so even if your local code does not differ from the code stored on USO - I guess they store some kinda "publication id" to compare with). But since the code doesn't differ, the Update does not really hurt - though I agree it is a bit annoying. So just press the Update button then, and you should be done (according to my experience).
    Posted By: Agnelo
    Posted By: IzzyYou mean notepad.exe could really make sense?
    I mean Windows doesn't make sense.
    Finally one who understood what I meant Cool
    'Save' and 'Cancel' is all you need in a clean design.
    The 'Save & Close' button is absurd.
    If you want an 'undo' feature, you should make an 'undo' button. However that feature isn't very useful and looks rather 'stuffy' here (my opinion).
    Partly agreed. To me, the "Save & Close" button absolutely makes sense: While working on a style, I might want to save the current state (since I solved one issue), but keep the window open (since I have to solve another) - instead of "Save" always closing the window and I have to permanently reopen it.
  • edited July 2009
    ^ yeap!

    And i've already said, name it what you will but Cancel and Close = discard all changes and close window. Another words, cancel editing and close this window. Another words, cancel what i'm doing and ...
    Izzy, got coffee there? Drink it!
    Smileys
    Posted By: IzzyYou just have to do this once for every style published on USO....
    I have over 100 ... not in a hurry ;-)
  • Posted By: Izzy
    Partly agreed. To me, the "Save & Close" button absolutely makes sense: While working on a style, I might want to save the current state (since I solved one issue), but keep the window open (since I have to solve another) - instead of "Save" always closing the window and I have to permanently reopen it.
    Press Escape on a Stylish window containing and unsaved style! It will ask you if you want to save it (great feature! :)) Press Enter, which means "OK", the default choice. That's it. The 'Save & Close' button is redundant as it doesn't add more functionality. It just sounds weird and catch the eye.
  • edited July 2009
    * I still haven't downloaded stylish custom yet - but what is extremely needed for me is:
    Save & Close Enabled
    and
    Save & close Disabled
    I would like those two choices EVERYTIME I save.
    Is that in there somewhere? Thankyou!

    * Also: Is there any way to automatically have Brackets { } wrap around where they are needed. And can squiggley brackets { } be red?

    * And, you know how in google search,after typing in your search request, google asks you:
    Did you mean...?
    Then you can click on it and it displays those new search results.
    Same with spelling error.
    What about in editor error? If you type in margon and error informs you of the error, and then says
    "Did you mean margin"
    and then you can click on it and it replaces margon and inserts margin.
    I guess that's waaaaaay out there and too difficult! Maybe 30 years away!
  • Posted By: AgneloA few remarks :
    I forgot to mention that IAT should not be selectable if it is not installed and that the correct spelling is "It's All Text!" (with an exclamation mark).
  • edited July 2009
    CHoGGi,
    please, leave the Save and Close alone. Rename it, whatever, just leave it there, please. I do not use Escape and never will. I'm a mouse person and it's too late for me to re-learn puters. Plus, i hate buggin' popups.

    Barbie,
    the edit window has a checkbox 'Enable' (doesn't seem to work though, i was going to mention this to CHoGGi anyway). You should be able to enable/disable and then save & close.
    The rest is - well, it's an editor w/in the editor. I don't think anybody wants to do that but then CHoGGi seems to take on just about everything ;-)
  • edited July 2009
    Posted By: Agnelo1) (cropped)
    2) What about making the button label text reflect the name of the choosen external editor (without path and extension) ?

    3) The drop down menu under the cancel button is unconventional and, I should say, rather annoying. Let it just be a 'cancel' button.
    1. maybe... as other people have mentioned it's just an example, i figure windows users need it more than anyone else :)
    2. shouldn't be too hard to do
    3. i'm probably going to rename it to Reset as makondo mentioned (there's always esc, but of course that does mean an extra click so i'll think on it)
    Posted By: makondoSorry, not sure what this means. Isn't selecting an option the same as resetting it? I Lclick to show the icon in the statusbar and there it is. I Lclick not to show - there it goes.
    it is kind of an annoying idea to do (when i add new options), and it isn't much use for most of the options. not sure if i'm going to keep it around
    Posted By: BarbiegirlSave & CloseEnabled
    and
    Save & closeDisabled
    I would like those two choices EVERYTIME I save.
    there's an enable checkbox and a save & close button
    for the brackets probably not (textboxes don't offer much in the way of neato features)
    might do something for spelling errors on save (but then stylish should report those anyways so guess not)
    Posted By: AgneloI forgot to mention that IAT should not be selectable if it is not installed and that the correct spelling is "It's All Text!" (with an exclamation mark).
    you should still have the option of picking iat maybe it's just disabled (i'll probably add a msg if it isn't found)

    edit:
    @makondo don't worry i use it too much to remove it
    the enable seems to be fine here (it only changes after you save)
  • Posted By: makondoCHoGGi,
    please, leave the Save and Close alone. Rename it, whatever, just leave it there, please. I do not use Escape and never will. I'm a mouse person and it's too late for me to re-learn puters. Plus, i hate buggin' popups.
    Then you click on 'save' to save and you click on the X button or whatever it looks like to close the window. It makes two clicks instead of one, which I guess is still acceptable for a mouse person, and presents less inconvenients than a useless and disturbing button.
  • edited July 2009
    Posted By: ChoGGithe enable seems to be fine here (it only changes after you save)
    Right. I forgot about it, sorry (even though i gave the correct instructions!).
    Posted By: ChoGGi... rename it to Reset as makondo mentioned...
    I believe, it was Izzy. I'm not too fond of 'Reset'. Cancel sounds perfectly fine to me - cancel my edits, don't know why it's so complicated all of a sudden. But if it only makes sense to me alone, then, by all means, call it whatever you wish.

    Just thought of something. How about Save/Undo button? That's where the Undo Last Save and Undo All can go. Maybe under Rclick on Save button? with a tooltip? But the Cancel button is still needed - for one, when you install a style/Preview/Cancel. Of course, you can just click the close window button as well ;-)
  • yeah whoops it was
    Posted By: makondoMaybe under Rclick on Save button
    that actually sounds pretty damn nice

    @Agnelo sorry, but i do like that button (#SaveClose{display:none} if you really don't want to see it)
  • edited July 2009
    Haha, i just came back to post this:

    #SaveClose,
    #CancelStyle,
    #save,
    #SwitchToInstall,
    #PreviewStyle,
    #ToggleEnabled,
    #stylish-bottom /* < the whole bottom buttons bar! */
    { display: none !important; }

    Smileys
Sign In or Register to comment.