Just want to jump in for a quick minute and say: I haven't downloaded stylish-custom yet as I'm waiting for all the wrinkles to be ironed out first. I am having too much trouble now with firefox to take on any more difficulties. But it looks so fantastic I can't wait to install soon! Big HUGE THANKS to ChoGGi but also thanks to all those contributing many hours of testing and feedback (especially our makondo) which we will all benefit from. * Would like to know if a clear button can be added to the search/find bar? * For Less letters, I thought stylish - custom should be called either: Stylish Extra Stylish Plus Stylish +
Stylish-Custom-0.4.3.xpi Import: it strips out carriage returns from css files now bit of a bug when importing xml (it didn't work) it doesn't add another style if you don't choose to overwrite (it used to add a dup style) doesn't work yet for xml with multiple styles Edit: it asked to save the style for imported css files that hadn't been changed Info: you can use enter to open the selected style
edit: @makondo probably the carriage return thing (although i didn't notice any crashing, see if it's any better now)
Posted By: AgneloJust a few aesthetic suggestions: - I think the correct answer to the question "Do you want to save the style?" should be "Yes" or "No" rather than "Cancel" or "OK". - To my understanding, "Cancel" means "do nothing". So it is supposed to restore the window without saving its content rather than killing it. In a "save and quit", "quit without saving" or "cancel" dialog, you would expect "Yes", "No" and "Cancel".
it's a stock prompt, not sure if i can change it much i thought the idea was you want to close it, but you also want it to save it if needs be (oh wait you don't want it closed though :)
Posted By: Barbiegirl* Would like to know if a clear button can be added to the search/find bar?
there's already one in the info dialog and if you use ff 3.5+ then there's also one for the edit dialog toilet bowl :) and @mild-mannered salesman you can thank bob for that line
edit2: now when it asks to save the style pressing cancel keeps the dialog open and there's a checkbox to save the style (it'll be in 0.4.4, i want to see about multiple xml import first)
Posted By: ChoGGiStylish-Custom-0.4.3.xpi i thought the idea was you want to close it, but you also want it to save it if needs be (oh wait you don't want it closed though :)
No, I don't want to close it. I close it accidentaly everytime when I press Escape and the window is still focused after I switched to another desktop to do a preview in FF. In vi, you press Escape everytime before typing a command, like a search/replace for example If the mouse is in the wrong window at this moment and the Escape key kills that window, you just lose your work. The idea was not to close the window but to prevent it from accidentaly closing without saving. Your confirmation dialog does that. As I wrote, my other suggestions were "aesthetic" and not essential.
Actually, it closes and saves which is what i was taking about back there somewhere. I think ... i'd like to see it working like this: Cancel - cancels your edits after the last Save but does not close the window. Save and Close is good as is. 'Close' button - i have no use for. But i definetely don't want it to save and close. I can click the designated button for that. So, will it close w/out saving but pop a 'Do you really want to?' OPTIONAL confirmation? I never use Escape unless i'm stuck in a full screen/frozen application. But if you'll add it, i see no harm (especially with an option to show/hide! ;-). And of course it should just close the window w/out saving anything by default - that is, disregard all changes after the last Save. See, i'm having the opposite problem as it is now - if i close the editor by the X in the upper right corner, it saves my changes, I have no way of closing it w/out applying (saving) changes from the originally opened style. So, when i'm uncertain about the changes i'm about to make, i have to copy/paste the style somewhere before doing anything. I remember having this discussion over a year ago when np asked what we want those buttons to do. I also remember we couldn't agree on anything ;-)
EDIT: OK, the latest version still kills my fox the same way (see my steps above to reproduce). Clicking the close window upper right corner button in the editor closes fox. Then a little window pops up asking if i want to save the style. However, there's no title in that window and you don't know which style it's asking you about! It simply has '...' in the left upper corner. It should ask you if you want to save 'such & such' style. For instance: i was editing a style and then drifted to something else totally forgetting the style was still open. I needed to restart Fx, so i did. As soon as the browser window closed, the pop up asked me if i want to save a style. Huh? i couldn't even remember i had one open let alone which one it was. And what if a few are opened? Will there be a list or diff. popup for each - even more reason for a style title in that case as you wouldn't know which one it's buggin' you about.
ChoGGi, please, make that popup an option. It really screws everything up for me and annoys beyond words. I install a style/click Switch to install - it's in my face along with install confirmation! I install a style/have to rename 'cause i'm just trying it and put them on top of my list/Save and Close - it's in my face! I really, really have no use for it! Also, you click Install button on USO. The editor pops up with 4! buttons to chose from: Save, Save and Close/Switch to Install/Cancel. That's an overkill of confusion, if you'd ask me. I can't think of any use for Switch to Install. None. Save and Close does it all. Let's say i preview and like it. Fine! Save and Close. Let's say i preview, change the title/code. Save and Close. Let's say i preview, don't like it. Cancel. Let's say i preview, don't like it, make changes, Save and Close or Cancel. So, what's the use for the Switch to Install? I'm going back to before the popup, 0.4.1 in the meanwhile (and will try to ignore the update notifier!).
Stylish-Custom-0.4.4.xpi Edit: now when it asks to save the style pressing cancel keeps the dialog open the save dialog shows the style name for the title Options: added an option to choose whether to ask to save changed styles
You might never press Escape, but please consider that other people do or might accidentally do. A program should provide the best accurate response to that event, other than brutally killing an editing window which may contain unsaved work. Such a behavior would be called a "severe bug" by any programmer. The dialog ChoGGi added was absolutely necessary.
@ChoGGi Now you got it: cancel does nothing (don't close the window), which is normal behavior. And "ok" saves and closes, which is what you would expect. Thanks again!
ChoGGi and Agnelo, that's why i said: '... if you'll add it, i see no harm (especially with an option to show/hide!...' and '...ChoGGi, please, make that popup an option...', right at the top of my posts;-) In my case it pops when i Save and Close, when i install, when i close the window .... that's not how i like things to work, sorry.
So, thank you very much for taking it off my face! Isn't it possible to pop it on closing window only IF a style has been edited AND the last click wasn't Save or Save and Close. Wouldn't this make much more sense? Sort of reminding you 'Hey, you didn't save it!' Even i will use it then ;-) Having lost a style once, i was going to ask about it anyway.
@makondo i was talking about the switch to install button (i'd mentioned before you could hide it, i doubt anyone would notice :) i was pretty surprised when somebody asked for it)
i set it to check when the dialog is closing, i'll see about that though (seems like a good idea) btw it shouldn't pop up for save and close or installs (it did do those in the first release, but it acts nice now) just when you try to close the dialog and the text is different from the saved code
edit: had some ideas about commenting and saving remove the uncomment and make comment either add comments as it usually does or if the selected text already is commented then remove them and for save make left click save as usual and rightclick save and close and maybe moving the replace box to the custom toolbar thoughts?
:) thought you would have liked less buttons (any thoughts on the rest)
#SwitchToInstall { display:none !important; } seems to work fine here. are you using an html namespace again :)
oh and changed the ask to save for 0.4.5 if you press cancel on an un-saved style it doesn't ask you (just for esc or the close button) it also doesn't ask when you close a style installed from userstyles.org
hey, i like your extension-extension, and thanks for the quick updates. i do have one suggestion: in the Stylish menu, separate the global styles from the site-specific styles. i have quite a few global styles, and this would make it much easier to find the style i'm looking for.
Posted By: ChoGGiare you using an html namespace again :)
But of course! ;-) Well, i deleted the namespace all together, was just messing my style. I really don't know why it was there, everything in there has something like #stylish this and that so, i guess, i don't need any namespaces after all (can you tell i have no idea what i'm talkin' bout? ;-) Anyway, the code works now, of course, the button is gone!
I have no thoughts about other buttons. They all seem (to me) to be useful and in place. I'm still not sure about all the uses for the Cancel button - you say the popup won't pop when canceling unsaved style. That's nice, pretty logical ;-) But, here's what was bugging me for a while - 'un-saved' since when? After the last Save or since the editor was opened? See, it would be great, but i'm not sure doable, if Cancel would really cancel. Like, you make some changes and save them as you go: save, save, save.... But then you decide 'Neh, hell with that, just leave it as is!...' ooops, too late! you clicked Save too many times! Do you get what i'm saying? You save incrementally and finally Save and Close OR! Cancel, at which point all those incremental Saves made after the style was opened, are gone and style is back to its original state. I don't know about Replace bar. Maybe make it a checkbox like the toolbar - Show/Hide?
Posted By: ChoGGi... it also doesn't ask when you close a style installed from userstyles.org ...
Stylish-Custom-0.4.5.xpi Options: changed the layout to use tabs (was getting a bit long) Edit: if you press cancel on an un-saved style it doesn't ask you to save it (just for esc or the X button) it also doesn't ask when you close a style installed from userstyles.org (or elsewhere) you will be asked if it's a new style also the dialog doesn't close anymore if you try to save a style without a name
if you edit a style, save it, then press cancel. it now reverts to the original style before you saved it removed uncomment button. comment does both now (it also ignores whitespace outside the slashes /) moved replace area (there's a checkbox to toggle it now) F3 will focus on search box if it's empty (F3 also works from the searchbox) i also made it so if it can't find anything it'll focus on the searchbox
Posted By: X1011_in the Stylish menu, separate the global styles from the site-specific styles.
you could try this #stylish-popup menuitem[style-type="global"]{color:#999!important}
Oh, that's what it is! I thought it means the Find bar .... and it does! How .... neat. However, i can hear somebody complaining now that you can only have one or another. I won't, i don't use Replace, well, i didn't yet. So, how's your Guide book going? ;-)
Posted By: ChoGGiif you edit a style, save it, then press cancel. it now reverts to the original style before you saved it
Isn't that confusing? Say I edit a style and save it, then leave the window open (to continue later) and forget about (for some more urgent work). Hours later I return to the window and cannot remember about it's state. In this case, say I want to continue with what was saved last, so I want to undo all changes done after the last save. So what? Close and open new? What would "cancel" mean to me if I didn't follow this thread? For sure not "Revert to something before the last save - at maximum I'd think of "revert to last saved state with the meaning "if nothing was done since, nothing will happen". Reverting to something before the last save should be more obvious to tell, IMHO (tooltip text, popup "do you really want...", button not simply labeled Cancel but something like Revert to xyz, which at least makes you stop for a centi-second and think it over) - it's too likely people are not aware of that behavior - and when they notice what happened it's already too late.
if you edit a style, save it, then press cancel. it now reverts to the original style before you saved it
That's not even a 'cancel' anymore. That's an 'undo'. Is it not a little bit exagerated? You could also enhance the 'search' in a 'search & replace'. Don't understand me wrong! I'm not asking you to do that. I think you're extension is fine. As somebody already suggested, you should rename it 'Stylish Plus'. But you're not going to do better than an external editor. It would be more logical and more efficient to implement a function which opens an external editor - even if it already exists in other extensions. From a programming point of vue, it doesn't matter to reinvent the wheel. Again, I'm not asking you to do that either. I'm just saying it would be more logical and more efficient.
Right. So... what am i missing again? Don't we have the 'external editor' button?
The problem with using an external editor is that you can't preview, for one. I use it usually to save the original and/or changes i'm sure i'll keep, just in case.
Comments
- FF 3,0.11 (Ubuntu and openSUSE)
- FF 3.5 (Fedora)
- FF 3.0.7 (OpenBSD)
I haven't downloaded stylish-custom yet as I'm waiting for all the wrinkles to be ironed out first. I am having too much trouble now with firefox to take on any more difficulties.
But it looks so fantastic I can't wait to install soon!
Big HUGE THANKS to ChoGGi but also thanks to all those contributing many hours of testing and feedback (especially our makondo) which we will all benefit from.
* Would like to know if a clear button can be added to the search/find bar?
* For Less letters, I thought stylish - custom should be called either:
Stylish Extra
Stylish Plus
Stylish +
* Also, would be nice if more of you post reviews
https://addons.mozilla.org/en-US/firefox/addon/12105
(which I will be doing after I install)
So funny ! mild-mannered salesman
https://addons.mozilla.org/en-US/firefox/addon/12105/developers
* Sorry dear ChoGGi, but the icon looks like a toilet bowl to me at
https://addons.mozilla.org/en-US/firefox/addon/12105
Will report back after I install. Thanks ChoGGi !
Import:
it strips out carriage returns from css files now
bit of a bug when importing xml (it didn't work)
it doesn't add another style if you don't choose to overwrite (it used to add a dup style)
doesn't work yet for xml with multiple styles
Edit:
it asked to save the style for imported css files that hadn't been changed
Info:
you can use enter to open the selected style
edit:
@makondo probably the carriage return thing (although i didn't notice any crashing, see if it's any better now) it's a stock prompt, not sure if i can change it much
i thought the idea was you want to close it, but you also want it to save it if needs be (oh wait you don't want it closed though :) there's already one in the info dialog and if you use ff 3.5+ then there's also one for the edit dialog
toilet bowl :)
and @mild-mannered salesman you can thank bob for that line
edit2: now when it asks to save the style pressing cancel keeps the dialog open and there's a checkbox to save the style (it'll be in 0.4.4, i want to see about multiple xml import first)
I never use Escape unless i'm stuck in a full screen/frozen application. But if you'll add it, i see no harm (especially with an option to show/hide! ;-). And of course it should just close the window w/out saving anything by default - that is, disregard all changes after the last Save.
See, i'm having the opposite problem as it is now - if i close the editor by the X in the upper right corner, it saves my changes, I have no way of closing it w/out applying (saving) changes from the originally opened style. So, when i'm uncertain about the changes i'm about to make, i have to copy/paste the style somewhere before doing anything.
I remember having this discussion over a year ago when np asked what we want those buttons to do. I also remember we couldn't agree on anything ;-)
EDIT: OK, the latest version still kills my fox the same way (see my steps above to reproduce). Clicking the close window upper right corner button in the editor closes fox. Then a little window pops up asking if i want to save the style. However, there's no title in that window and you don't know which style it's asking you about! It simply has '...' in the left upper corner. It should ask you if you want to save 'such & such' style. For instance: i was editing a style and then drifted to something else totally forgetting the style was still open. I needed to restart Fx, so i did. As soon as the browser window closed, the pop up asked me if i want to save a style. Huh? i couldn't even remember i had one open let alone which one it was. And what if a few are opened? Will there be a list or diff. popup for each - even more reason for a style title in that case as you wouldn't know which one it's buggin' you about.
Also, you click Install button on USO. The editor pops up with 4! buttons to chose from: Save, Save and Close/Switch to Install/Cancel. That's an overkill of confusion, if you'd ask me. I can't think of any use for Switch to Install. None. Save and Close does it all.
Let's say i preview and like it. Fine! Save and Close.
Let's say i preview, change the title/code. Save and Close.
Let's say i preview, don't like it. Cancel.
Let's say i preview, don't like it, make changes, Save and Close or Cancel.
So, what's the use for the Switch to Install?
I'm going back to before the popup, 0.4.1 in the meanwhile (and will try to ignore the update notifier!).
Edit:
now when it asks to save the style pressing cancel keeps the dialog open
the save dialog shows the style name for the title
Options:
added an option to choose whether to ask to save changed styles
@makondo someone asked for it, so i added it
You might never press Escape, but please consider that other people do or might accidentally do. A program should provide the best accurate response to that event, other than brutally killing an editing window which may contain unsaved work. Such a behavior would be called a "severe bug" by any programmer. The dialog ChoGGi added was absolutely necessary.
@ChoGGi
Now you got it: cancel does nothing (don't close the window), which is normal behavior. And "ok" saves and closes, which is what you would expect. Thanks again!
that's why i said: '... if you'll add it, i see no harm (especially with an option to show/hide!...' and '...ChoGGi, please, make that popup an option...', right at the top of my posts;-)
In my case it pops when i Save and Close, when i install, when i close the window .... that's not how i like things to work, sorry.
So, thank you very much for taking it off my face! Isn't it possible to pop it on closing window only IF a style has been edited AND the last click wasn't Save or Save and Close. Wouldn't this make much more sense? Sort of reminding you 'Hey, you didn't save it!' Even i will use it then ;-) Having lost a style once, i was going to ask about it anyway.
Things are working as expected here. It only pops when I press Escape.
i set it to check when the dialog is closing, i'll see about that though (seems like a good idea)
btw it shouldn't pop up for save and close or installs (it did do those in the first release, but it acts nice now) just when you try to close the dialog and the text is different from the saved code
edit: had some ideas about commenting and saving
remove the uncomment and make comment either add comments as it usually does or if the selected text already is commented then remove them
and for save make left click save as usual and rightclick save and close
and maybe moving the replace box to the custom toolbar
thoughts?
button[label="Switch to Install"] or #SwitchToInstall { display:none !important; }
About Save .. i use Save and Close a lot. I'd rather it stays than trying to remember which click when.
#SwitchToInstall { display:none !important; } seems to work fine here. are you using an html namespace again :)
oh and changed the ask to save for 0.4.5
if you press cancel on an un-saved style it doesn't ask you (just for esc or the close button)
it also doesn't ask when you close a style installed from userstyles.org
in the Stylish menu, separate the global styles from the site-specific styles. i have quite a few global styles, and this would make it much easier to find the style i'm looking for.
Well, i deleted the namespace all together, was just messing my style. I really don't know why it was there, everything in there has something like #stylish this and that so, i guess, i don't need any namespaces after all (can you tell i have no idea what i'm talkin' bout? ;-)
Anyway, the code works now, of course, the button is gone!
I have no thoughts about other buttons. They all seem (to me) to be useful and in place. I'm still not sure about all the uses for the Cancel button - you say the popup won't pop when canceling unsaved style. That's nice, pretty logical ;-) But, here's what was bugging me for a while - 'un-saved' since when? After the last Save or since the editor was opened? See, it would be great, but i'm not sure doable, if Cancel would really cancel. Like, you make some changes and save them as you go: save, save, save.... But then you decide 'Neh, hell with that, just leave it as is!...' ooops, too late! you clicked Save too many times! Do you get what i'm saying? You save incrementally and finally Save and Close OR! Cancel, at which point all those incremental Saves made after the style was opened, are gone and style is back to its original state.
I don't know about Replace bar. Maybe make it a checkbox like the toolbar - Show/Hide? Thank you!
I try my best ;-)
Options:
changed the layout to use tabs (was getting a bit long)
Edit:
if you press cancel on an un-saved style it doesn't ask you to save it (just for esc or the X button)
it also doesn't ask when you close a style installed from userstyles.org (or elsewhere)
you will be asked if it's a new style
also the dialog doesn't close anymore if you try to save a style without a name
if you edit a style, save it, then press cancel. it now reverts to the original style before you saved it
removed uncomment button. comment does both now (it also ignores whitespace outside the slashes /)
moved replace area (there's a checkbox to toggle it now)
F3 will focus on search box if it's empty (F3 also works from the searchbox)
i also made it so if it can't find anything it'll focus on the searchbox
you could try this
#stylish-popup menuitem[style-type="global"]{color:#999!important}
0.4.5: I just like it how we think in unison, i was just about to ask if you could, please ;-) Great! did you forget to add it somewhere? or do i need a second pair of glasses?
So, how's your Guide book going? ;-)
Thanks, ChoGGi!
been around for a bit (i stuck a link in the first post) http://choggi.dyndns.org/wiki/stylish-custom
i'll need to update it for some new stuff i think
also changed cancel to close, as it doesn't really cancel anything
You could also enhance the 'search' in a 'search & replace'. Don't understand me wrong! I'm not asking you to do that. I think you're extension is fine. As somebody already suggested, you should rename it 'Stylish Plus'. But you're not going to do better than an external editor. It would be more logical and more efficient to implement a function which opens an external editor - even if it already exists in other extensions. From a programming point of vue, it doesn't matter to reinvent the wheel. Again, I'm not asking you to do that either. I'm just saying it would be more logical and more efficient.
2. ChoGGi, how about a Cancel or Undo button with a dropdown menu with 2 items:
Cancel the Last Save
Revert to the Original or Undo All Changes
I don't use keys and i can't remember them all.
The problem with using an external editor is that you can't preview, for one. I use it usually to save the original and/or changes i'm sure i'll keep, just in case.