Getting better!
Love this theme would like to report yet another dreaded white box area (the shopping cart popover frame on right side) screenshot here:
https://1drv.ms/u/s!AhSqjTYUuHPKgcNQO_M4xjJb6k_VCA
Also, I would LOVE an option (either here at installation time or just even a script comment on the line number) to be able to change the background to my own dark pattern as I do in others with that option - just an idea.
Thanks again for the hard work on this!
https://1drv.ms/u/s!AhSqjTYUuHPKgcNQO_M4xjJb6k_VCA
Also, I would LOVE an option (either here at installation time or just even a script comment on the line number) to be able to change the background to my own dark pattern as I do in others with that option - just an idea.
Thanks again for the hard work on this!
Comments
https://1drv.ms/i/s!AhSqjTYUuHPKgcNRqjIfzD8_XiJHww
Problem item layout (note the "add to cart" button area):
https://1drv.ms/i/s!AhSqjTYUuHPKgcNSTuuCUgamZ4R3RA
vs every other ASIN the "add to cart" area is a different layout that is themed properly:
https://1drv.ms/i/s!AhSqjTYUuHPKgcNT_W0qf3IC8OeW-Q
Seems weird to me but no matter how many refreshes, it seems like there are at least a couple if not more possible item layouts which sure seems dumb.....and makes pretty tough to theme. :)
Thanks so much for the pictures, I'll hopefully have those fixed up by days end for you! Great feedback much appreciated.
Sean
https://smile.amazon.com/gp/product/B01092XXD4
Now here is a "normal" or "typical" USA ASIN I see:
https://smile.amazon.com/HATCHBOX-3D-PLA-1KG1-75-TBLU-Dimensional-Transparent/dp/B00M0CS4YA
Note the layout/look really does not change other than a small banner at top for the "smile" vs the "www" URL the smile is just to give to charity with the purchase and I try to use it whenever I can.
As for that weird layout issue, I'm really struggling to find the cause, is it literally only that item?
Hey hate to lay another one on you but this may actually help you figure out what's going on.......2 ASINs very similar layouts the ONLY difference on these 2 I can find is one is offering the subscribe/save and as you can see in screenshot it makes that whole box white but otherwise identical layouts:
Broken:
Okay:
EDIT: I tried to at least assist and nail down which CSS is problematic for you so the 2nd screenshot for each above shows what's happening - the additional element class on the missing white box not sure what Amazon was thinking but their CSS is really complex.
Amazon css is terrible, it doesn't cascade at all, that's why it's so time consuming to theme.
Looks much better you did get that white box on that weird ASIN here's the screenshot just to point out (and I helped by getting you the CSS element that's missing) the common box indicating if you have already purchased an item has always been missing in the theme and it's element is in the 2nd screenshot for you if you want to add it. Figure I'll try to be part of the solution and learn along too rather than just point out problems without offering anything. :) Also, I wanted to take the time to better format in markdown these issues as I report them to make it that much easier for you since you already put so much work into creating the theme to begin with!
Two Elements Still Needing Theming:
BUG 1: "Already purchased" white box
Issue:
Here is that fixed ASIN (to confirm that fix is good) but shows the "already purchased" unthemed box:
Click here for screenshotSolution:
Here is the CSS element missing (a-box-inner a-alert-container):
Click here for screenshotBUG 2: "Dynamic Shopping Cart Dock" white box
Issue:
Also, in the same screenshot below you can still see that dreaded "shopping cart" white slider box that only appears....get this I figured out the missing darn piece of why you could not get it to show....drumroll....your browser width MUST BE 1400px for it to magically appear!! Once it does slowly resize down the width once you hit 1399 and watch the darn thing disappear....I bet anything when you were testing that your width (MUST ALSO BE OUTSIDE OF THE DEV DOCK 1400 ITSELF) was less than 1400! I nailed down what CSS element might be missing for you to try (element is div class="ewc-scroll-area"!!)
Click here for screenshotSolution:
Here is the CSS element missing (div class="ewc-scroll-area"):
Click here for screenshotSo since I'm really enjoying getting into this (can you tell?) have to ask I use Windows 7 x64 and Chrome just with the builtin DEV f12 tools to inspect CSS, since you are an official "theme builder" I have to ask, if you don't mind telling me what tools/utils do you use to map out and identify all the CSS as you build a userstyle/userscript? Just looking for a leg up to be more efficient if possible!
As for tools, I simply use Firefox developer edition for styles much the same as you do in chrome but it's better in that particular version of Firefox imo. I will then usually use notepad++ to lay it all out, sometimes I just do it straight in stylish....like this amazon one, which is coded messily.
Sorry have 2 babies at home so have had hands full will try to check it out soon.
So you know I had a note here in notepad that I forgot to send you, line 392 (of my converted userscript.js version) has a kind really bad practice IMO and isn't even working (because assuming it's your dropbox?) now says it isn't even valid, anyway is trying to tell everyone's browser to pull an image from dropbox in this line:
Just wanted you to know like I said that account is now dead (hopefully this didn't get it banned, LOL!). I can't even tell from a glance what header graphic is that supposed to replace?