Release Notes - Stylish 1.6.3 is out!
It wasn't easy to make it in such a short time, but I knew it was important for you guys.
Included changes in this version:
- Added ‘Installed Styles’ tab - which lets you edit, enable/disable and delete styles
- Added a ‘Turn all styles on/off’ toggle
- Improved the logic behind the styles shown on the ‘Style Library’ tab - should be more accurate now (right now it's still only based on weekly installs)
- Set the latest visited tab as the default one in the next time Stylish is opened
Let me know what you think.
Included changes in this version:
- Added ‘Installed Styles’ tab - which lets you edit, enable/disable and delete styles
- Added a ‘Turn all styles on/off’ toggle
- Improved the logic behind the styles shown on the ‘Style Library’ tab - should be more accurate now (right now it's still only based on weekly installs)
- Set the latest visited tab as the default one in the next time Stylish is opened
Let me know what you think.
Comments
I have about a 500px high, blank space with this garbage:
"You chose to opt-out from seeing available styles for this site directly on Stylish. Visit Userstyles.org to see available styles, or update your settings to see them here."
My res is 1366x768. The viewport is like 640px high. Your popup is somewhere close to 600px and practically the entire visible height is an error message and blank wasted space. This isn't some oversight. One of you geniuses wrote this:
#nostyles, #unavailable-message, #noServerConnection {The "error" message shouldn't be there at all, let alone an extra 393px padding/margins. What a joke.height: 57px;
font-size: 16px;
font-weight: 500;
font-style: normal;
font-stretch: normal;
text-align: center;
color: #2c3e50;
padding: 25px;
margin-top: 130px;
margin-bottom: 213px;
}
Scrollbars in extension popups have been buggy in Chrome the last couple versions. If anything good comes from this, maybe it's that more people will complain, because you've got scrollbars, lots of scrolling in your popup.
Scrolling past the error message, you get a tab where the functionality has supposedly been added back. The "controls" for each style have pictures and are over 200px tall, so if you have more than two....more scrolling!
Don't worry though, odds are you won't have more than two, because if they're not published on us.o, they don't exist. Personal styles? You are not the end user!
It's like someone who never used the extension is redesigning it to be an annoying popup ad for us.o. You don't need to drive traffic, you are practically the only game in town.
One link: "find styles for this site"....done.
If you keep this up, you will have competition, because people will start to hate you, so there'll be an opportunity for anyone ambitious. It's already starting:
https://chrome.google.com/webstore/detail/stylish/fjnbnpbmkenffdnngjfgmeleoegfcffe/reviews
Oh, and the icon is still buggy:
Is this a joke? If I opt out of the so-called 'Style Library' the popup menu is rendered useless with an enormous "enable the Style Library" nag [screenshot 1]. Part of one style is visible at the bottom, no more. There are a few installed styles listed below it, but there are no scrollers in the popup, not even a hint that you can scroll, and the styles list isn't focused by default, so most users will have to stumble onto their presence.
There are still no scrollers if you opt-in to the spyware, but the enormous nag is gone so you can see more installed styles. However, only seven styles are listed. If you have more than seven styles installed then your enabled styles may or may not be in the list [screenshot 2].
Did I say spyware? If you opt-in to the 'Style Library' then Justin collects every URL you browse to, along with the URL of the page you were just viewing. That is, he's collecting your complete browsing history. See for yourself: browse to chrome://extensions/, inspect the Stylish background page, select the Network tab, and click on one of the 'stats' entries. At the end of 'Headers' you'll see an entry 'e' in the 'Form Data' [screenshot 3]. In the 'Console' tab you can decode that with The 'to' and 'from' URLs are gp= and ver=.
That's incredibly, unnecessarily invasive. All that's needed for this 'Style Library' is the URL of the page you're viewing when the popup menu opens. Not every page you've ever loaded, and certainly not a complete record of your browsing history. The 'Style Library' itself is useless - 'Install' doesn't install the style or even let you preview it, it merely takes you to the Userstyles style page.
Tell your ninja that the knife goes in the other guy.
Please
Mostly though un-fsck Stylish.
I couldn't reproduce the browsing history collection in opt-out mode. It will help if you could include specific steps to reproduce or, even better, take a screen capture to show me how you're reaching this scenario.
Regarding the collected installed stats, it seems you misunderstood that line of code. The call to the server is to the thumbnail of the style and no data is saved, general or personal.
All my checks show that when you opt out, no data is collected. But again, if I missed something, just provide me with an easy way to reproduce it and I'll handle it.
I'm handling the scroll down of 'Installed Styles' in opt-out mode bug (thanks for reporting it!). Will probably release it either this week or sometime next week, with some other features I'm working on.
As for what you described as an inconvenience, I can't understand how it's an issue.
The extension is configured so that you'll always see the last visited tab. So practically, you never even have to set your eyes on the 'You're opted out' message. If you still think there's a problem I'm missing here, you'll have to explain why having a default tab isn't a good enough solution.
You seem to have completely missed the biggest issue though. The fact that you're saying that you returned the functionality for disable/edit/delete styles couldn't be any more untrue. I do think that you know so little about how it actually functioned before that you think you've returned the functionality, but you haven't. Telling people that you have in the WebStore will not end well for you. hippyjake is right, releasing betas here for a week or two and getting feedback from us is how it's always been done, and it will save you a lot of grief. Even pushing to 5% is a lot of people. Most updates have bugs to some extent.
Back to what you don't know that you don't know. On any given site, the popup should show every style that is, or could be applied to that site. Styles for that site and global styles, enabled or disabled. That way, you can quickly and conveniently control or go directly to any of them. You have returned that functionality for styles installed from us.o only. Over 90% of my styles are personal styles and the others are personal styles that I've published on us.o, so practically none show up in the popup.
I made two comparison screen records to show the difference on this page. I have 3 styles enabled for this forum and 3 global styles (2 active and 1 disabled). In Jason's last unpacked master, you'll see them all, as you should. In yours, you'll see only my scrollbar style, because it's the only one published to us.o. So...pretty useless.
Previous version: https://vid.me/5HFM
Your version: https://vid.me/Tm85
You'll also notice that the icon doesn't change colors at all. I still find it odd that no one else has encountered this issue.
I appreciate the concept of the tab, and the fact that it remembers the preference. If it had the correct stuff in it, it'd be alright. Assuming you actually will return the functionality, I will continue to urge you to format the list of styles as compact as possible. Each style doesn't need to be 200px high, with a pic. Just the name and controls. A simple list format as compact as possible. Some people will have many styles for a site and many global styles, and nobody wants to go scrolling to find them. Plus, once you add the controls for personal styles, the big production entries for us.o styles will be even more ridiculous looking mixed in.
As for the privacy issues brought up, when it comes to technical facts, I hate to admit that hideheader is typically correct. I would also have a huge problem with it, but hopefully we can take you at your word that you are not an NSA operative, and that if there is a problem it'll be corrected. No need to collect info that isn't necessary, or any at all if opted out.
The point is not to have ONE checkbox that turns off ALL styles, but to have a LIST of installed styles, EACH of which can be enabled or disabled individually.
Clearly, Stylish knows that I have four styles installed, but NONE of them is listed in the so-called "Installed Styles" tab:
What I'm reasonably certain that what EVERYBODY wants is this:
I've never found a way to solve this. Do you know any solution?
Curiously, thumbnail requests for suggested styles hit the cache, but requests for installed styles don't. Also, you're throwing errors right and left. You can see some of the debris as null.json requests in the screenshot I provided. Hmm. Earlier you said that all of your checks showed no Userstyles database corruption, and it quickly became obvious that either you were handing out empty assurances or else your checks were woefully cursory and uninformed. You'll understand that my index of suspicion with respect to your assurances is quite high now. What exactly did you check, and how? Don't be disingenuous. That was a design decision, not a bug. Specifically, line 72 of styles.css
::-webkit-scrollbar {Please stop trying to force us to use what doesn't work. Make the change now and bank some goodwill against all of what Jason gave you and which you've since pissed away. I don't believe anyone will welcome more of your new features until you've addressed the problems with what you've already done.display: none;
}
I did expect some cogent explanation of why only 7 styles are listed in the installed tab, why the active styles aren't listed first, why inactive styles are listed when active styles are omitted, and why you push the whole damned menu below the oversized 'enable my spyware' nag. Distracted, or just ignoring those questions?
Edit: nevermind I found it, but by god does it make stylish popup ugly when you opt-out...
There's an option to just remove the nag.
Maybe you're seeing a bug. Like the "Offline? No styles for you!" bug [screenshot 3] or the "Styles? What styles?" bug [screenshot 4].
... Notice the coloured icon in screenshots 1 & 2. The nags say data collection was refused, the icons indicate that styles are available. (In fact, opted-out for 1 & 2, opted-in for 3 & 4). The menu seems to become uncoordinated very easily.
Stylish needed an update (visually) this whole ugly site needs an update, and its all in Justin's hand, unless you want to beg him to take his place?
TL;DR We or I just want something attractive that doesn't hinder ease of use, or skimp on old useful features.
Goal: keep it pretty but compact + keep old features
The functionality is there, it exists (see attached image). I tested it on multiple sites, but of course, there can always be end cases that require special care or that indicate a scenario that was missed. If you're a developer you should know that and I expect better of you and others in this forum.
As with any bug reporting, I'll need more details to be able to help you, like the domain name. If you don't want to share it publicly, you're welcome to PM me. But seriously man, it's like I'm talking with people that have never developed something and have never had feedback given to them about bugs. It's pretty simple - include steps to reproduce or I won't be able to help you.
And hay, this is Stylish, so you guys are welcome to create suggested designs or even send me screenshots of your own vision of Stylish.
As for the icon color, the way it works is when you visit a site it sends a call to the server checking if styles exist for the visited web page. If you opted out, you're not allowing this information to be sent. That's why it's not able to show the color indication. If you have a better solution, I'd be happy to hear it.
Also a more direct question regarding the harvesting of urls and other stat data on users.
Justin, are you gathering user data like urls, pages, times, usage habits and IP's - and other stat data, and selling onto other 3rd party entities ?
Now that I know it's a bug, it fails to list installed styles on lots of pages. Some are, as you surmised, instances of my employer's web apps, not for the public. Here's an example from a public site:
The style and its config couldn't be simpler:
Let's not get testy. I'm trying to help you improve a beloved tool.
It remains that way through multiple pageloads. While testing this time, restarting the browser got rid of it. I don't remember if I made it that far the first time.
If you reverse the order (as I must've done the second time installing), and opt-out of analytics, then close Chrome, replace the IndexedDB folder and restart, the nag is gone.
I don't know if/how this bug affects a pushed update, or installing the new version over a previous version. It may or may not.
The issue of the missing scrollbars is bizarre. I hadn't noticed previously because I have a global scrollbar style that forces
display:initial!important;. When I disabled my scrollbar style, scrollbars disappeared in the popup. Sure enough, for some ridiculous reason, you've added this code to the popup:::-webkit-scrollbar {On to the biggest issue. It's becoming difficult to ascertain whether you're having trouble discerning which specific issues being brought up need to be addressed, or if you're selectively ignoring issues to which your answers will be unpopular and unacceptable. I'll make one more attempt. This is the main issue practically everyone is unhappy about...PLEASE DIRECTLY ADDRESS THIS ISSUE: I can understand your frustration trying to comprehend certain issues reported here. Most of us seem more familiar with all the previous functionality of Stylish than you are, but I actually made two comparison videos to demonstrate. It doesn't get much more informative than that. I think what you meant to say is "the way it works now, after I stripped more useful functionality and replaced it with nonsense".display: none;
}
The icon has always changed from grayscale to colored to indicate that styles are actively being applied to any given site. A much more useful indicator than an advertisement for available us.o styles. So...completely useless. Revert back to its useful functionality...and stop replacing useful functionality with not-so-subtle advertisements for us.o in general.
I find in a Chrome store review that 1.6.3 has only been released to 5% of the users...
The irony is that I was unlucky enough to be in the 5% that 1.6.2 was initially rolled out to - so back to the waiting game.
What I think would be really cool though is, Release 2 different versions, one for creators, and one for users. That way, you could quickly just rerelease 1.5.2 renamed as a creators version. Saves you tons of time, and you can just focus on the dumb down version for just the plain users. That way, everyone that was happy with the old version gets that back, and the normal users probably won't realize how much they lost.
Because jumping through all these extra hoops to do what I was so easily able to do before, has gotten very, very old already.
I am a style creator, not a style consumer.
I was just surprised by seeing this:
I have 212 styles installed (maybe 20-30 active at any time). Only one or two were downloaded from userstyles.org. The image above is the first time I've ever seen anything in that panel, and now I think I know why: did you forgot (or intentionally decide not) to show user-created styles in the "Installed Styles" tab?
Those of us for whom Stylish is a tool and not a toy would appreciate it.
If you want to show your "fancy" displays for userstyle.org-originated items, that's no concern of mine, but user-created styles could be listed as I mocked up above: a simple text listing with a toggle and either a menu (as mocked up) or plain text links below the title for Edit/Delete/Clone.
Thanks!