Bug Alert

Justin Hindman · October 2016

I really need your help to pinpoint bugs and prioritize them.
Use this thread to add bugs you come across on Stylish. It would be great if you could include steps to reproduce the bug and how urgent you think the fix is (urgency levels: not very/very/crucial).

Thanks!

Dante_MS · October 2016

Will corrupted styles get fixed or we have to restore them by ourselves?

Andy Cormack · October 2016

Urgency level: crucial

Ok, so first off my Youtube Umbra style: https://userstyles.org/styles/130610/youtube-umbra got corrupted and about 90% of the code disappeared, I restored that but now my style isn't showing up on search results at all and the installs stat is completely screwed.

I'm not sure what happened with the changing of hands on this site but there seem to be some MAJOR issues happening at the moment.

Mikhoul · October 2016

Not a bug but a big questions for Users of Stylish: Are you going to continue to develop the Stylish addons for Firefox and Chrome ?

What qualifications do you have as a dev ? What have you done in the past in the dev community ?

Regards :bz

calico · October 2016

As a note, I'm editing any style review down-votes related to site issues to no rating.

hideheader · October 2016

Bugs:

critical Cat's got your tongue. You need to communicate the scope of the problem, pronto. Are the broken styles safe in the database or are they really broken? If broken, how old is the backup database? Is it safe to upload/update a style? Is it safe to install a style? All of them, some of them, or what?
critical Userstyles is delivering corrupt files. Stylish can't detect a corrupt download - the md5 URL returns an opaque update token as far as it's concerned - so this needs to stop ASAP. Any 16KB+ (uncompressed) .css file probably already has a corrupt gzip in the caboodle, and if the corresponding .json file was generated at the same time then it's surely corrupt, too. Change the permissions if you have to until this is sorted - better a 404 than a bad file. Style consumers are the site's revenue and its reputation, and aren't as forgiving as style producers.
pressing Install counts are stuck. Installs guide consumers to good styles and reward authors for writing them. (Authors work cheap here.) They're the coin of the realm, and currently we're experiencing severe deflation. If it persists output will contract.
pressing Sphinx search isn't being updated. Search can't find new styles, including "Find styles for this site" in Stylish.
annoying No automatic screenshots. Not since July. Because they're only semi-automatic.
annoying Forum "views" counts are stuck. If they were working you would have seen immediately that there was trouble in River City. (Though usually it would be a catfight, not real trouble. Maybe you are jinxed.)

pierO'nMu · October 2016

Andy Cormack said:
Urgency level: crucial

Ok, so first off my Youtube Umbra style: https://userstyles.org/styles/130610/youtube-umbra got corrupted and about 90% of the code disappeared, I restored that but now my style isn't showing up on search results at all and the installs stat is completely screwed.

I'm not sure what happened with the changing of hands on this site but there seem to be some MAJOR issues happening at the moment.

Same here with my facebook theme https://userstyles.org/styles/118180/dusky-gray-facebook-dark-theme. I was the first with about 5000 installs per week... and now... 6
I've already restore the code manually...
I hope everything go back to normal soon. Thanks

EDIT: My theme has just disappeared on any search results (relevance, created, updated...) even if I was the first... It's annoying!

Sean Mayes · October 2016

Nice post hideheader, completely agree on it all.
Themes not showing up at all in searches is my main beef, kind of makes them useless for anybody but myself if they never appear.

decembre · October 2016

Flickr Widescreen - ALLinONE TOTAL (No GM) v.33 is corrupted...

It miss a big part of it .
Can you fiX it?

Rahimichi · October 2016

Yeah same here I just updated one of my styles and that particular style is not showing up on search whereas another persons style with a similar name is, and yes the "Find styles for this site" is not showing my style as well, slightly annoying but hope it gets fixed.

Also haven't been in the forums for a while, but wow a mysterious new leader.. who are you? Has this ship sank even further to where spongebob is? O.o

EDIT: My style now shows up on search here now just install counts are still broken.

Justin Hindman · October 2016

Dante_MS said:
Will corrupted styles get fixed or we have to restore them by ourselves?

If you can send me some examples of corrupted styles, I'll see if there's a global fix. If it's going to require a fix per style, I'll probably have to ask you guys to take care of your own styles.

Dante_MS · October 2016

Justin Hindman said:

Dante_MS said:
Will corrupted styles get fixed or we have to restore them by ourselves?
If you can send me some examples of corrupted styles, I'll see if there's a global fix. If it's going to require a fix per style, I'll probably have to ask you guys to take care of your own styles.

https://userstyles.org/styles/52167/flickr-widescreen-allinone-total-no-gm-v-33
https://userstyles.org/styles/119996/almost-fully-customizable-last-fm
https://userstyles.org/styles/128894/facebook-dark-and-easy-on-the-eyes
https://userstyles.org/styles/84054/darker-tumblr
https://userstyles.org/styles/80958/tumblr-midnight-chrome-dashboard
There are a lot of them.

Justin Hindman · October 2016

Andy Cormack said:
Urgency level: crucial

Ok, so first off my Youtube Umbra style: https://userstyles.org/styles/130610/youtube-umbra got corrupted and about 90% of the code disappeared, I restored that but now my style isn't showing up on search results at all and the installs stat is completely screwed.

I'm not sure what happened with the changing of hands on this site but there seem to be some MAJOR issues happening at the moment.

I search for ‘Youtube Ubra’ and got your style in the search result. Can you be more specific about this specific bug?

Regarding the install count, I assume you mean the weekly ones, since the total seems to be ok. I'll look into this and will keep you guys posted when I know more.

Justin Hindman · October 2016

hideheader said:
Bugs:
critical Cat's got your tongue. You need to communicate the scope of the problem, pronto. Are the broken styles safe in the database or are they really broken? If broken, how old is the backup database? Is it safe to upload/update a style? Is it safe to install a style? All of them, some of them, or what?
critical Userstyles is delivering corrupt files. Stylish can't detect a corrupt download - the md5 URL returns an opaque update token as far as it's concerned - so this needs to stop ASAP. Any 16KB+ (uncompressed) .css file probably already has a corrupt gzip in the caboodle, and if the corresponding .json file was generated at the same time then it's surely corrupt, too. Change the permissions if you have to until this is sorted - better a 404 than a bad file. Style consumers are the site's revenue and its reputation, and aren't as forgiving as style producers.
pressing Install counts are stuck. Installs guide consumers to good styles and reward authors for writing them. (Authors work cheap here.) They're the coin of the realm, and currently we're experiencing severe deflation. If it persists output will contract.
pressing Sphinx search isn't being updated. Search can't find new styles, including "Find styles for this site" in Stylish.
annoying No automatic screenshots. Not since July. Because they're only semi-automatic.
annoying Forum "views" counts are stuck. If they were working you would have seen immediately that there was trouble in River City. (Though usually it would be a catfight, not real trouble. Maybe you are jinxed.)

First of all, amazing feedback man. It's really helpful.

In the meantime I can answer some of your questions – the DB is secure, stable and backed up. I don't see a reason for problems with installing styles or updating them. I’ve switched to RDS, where we get auto backups. I suspect that some of the corrupted styles were caused by partially blocked traffic due to NGINX limits. I made some changes yesterday, which I believed resolved this issue.

There are two options now – you can restore your styles, which I believe will get them back on track, or you can wait till I continue and investigate this and possibly be able to make changes that will automatically adjust your styles to the new machines.

pierO'nMu · October 2016

In this screenshot of my stats, we can clearly see when it gets stuck!
https://userstyles.org/styles/118180/dusky-gray-facebook-dark-theme

Andy Cormack · October 2016

Justin Hindman said:

I search for ‘Youtube Ubra’ and got your style in the search result. Can you be more specific about this specific bug?

Regarding the install count, I assume you mean the weekly ones, since the total seems to be ok. I'll look into this and will keep you guys posted when I know more.

The search result, at least, seems to have fixed itself after some hours, not sure if that was some tinkering on your end in general or not?

As for the install count, yes I mean the weekly one.

anagrammar · October 2016

The install count is crucial, but the fact that a significant portion of styles were mangled in the migration is critical. The only people who know how many for sure are you and maybe Jason if he hasn't washed his hands of this already. The size limit for styles is 100kb. When you switched servers, every style was cut off ~16kb. The majority of styles will be under 16kb, but a lot (a wild guess would be 10% maybe) were cut off and corrupted. Typically, data images aside, the longer the code, the more work went into it, so these longer styles tend to be some of the nicer ones.

Counting on authors to fix them is naive. Some are actively involved and will update, but most aren't and won't. If you do have a backup and can fix it, the longer you wait the worse it'll be. You'll end up overwriting new updates and making the whole process more of pain in the ass than it already is.

If you don't have a viable backup, or decide for whatever ill-advised reason not to bother, you'll need to validate styles and do a mass deletion. You can't continue serving up corrupted code to unsuspecting users.

Justin Hindman · October 2016

anagrammar said:
The install count is crucial, but the fact that a significant portion of styles were mangled in the migration is critical. The only people who know how many for sure are you and maybe Jason if he hasn't washed his hands of this already. The size limit for styles is 100kb. When you switched servers, every style was cut off ~16kb. The majority of styles will be under 16kb, but a lot (a wild guess would be 10% maybe) were cut off and corrupted. Typically, data images aside, the longer the code, the more work went into it, so these longer styles tend to be some of the nicer ones.

Counting on authors to fix them is naive. Some are actively involved and will update, but most aren't and won't. If you do have a backup and can fix it, the longer you wait the worse it'll be. You'll end up overwriting new updates and making the whole process more of pain in the ass than it already is.

If you don't have a viable backup, or decide for whatever ill-advised reason not to bother, you'll need to validate styles and do a mass deletion. You can't continue serving up corrupted code to unsuspecting users.

I agree that we shouldn't be counting on authors to fix this. I'm on it and hope to be able to update you guys tomorrow. If you bump into any additional pointers that can help figure this out, do share. Jason is still here supporting me.

Justin Hindman · October 2016

Andy Cormack said:

Justin Hindman said:

I search for ‘Youtube Ubra’ and got your style in the search result. Can you be more specific about this specific bug?

Regarding the install count, I assume you mean the weekly ones, since the total seems to be ok. I'll look into this and will keep you guys posted when I know more.

The search result, at least, seems to have fixed itself after some hours, not sure if that was some tinkering on your end in general or not?

As for the install count, yes I mean the weekly one.

Glad to hear that the search issue was fixed. I know the weekly install count is important and am working on resolving that too.

hideheader · October 2016

Justin Hindman said:
I don't see a reason for problems with installing styles or updating them.

The problem continues to be that "large" styles (> 2^14 bytes) were truncated before being gzipped or converted to .json. The reason is probably that by starting with an empty cache you overran the database capacity, ran out of some resource - processor time, memory, connections, whatever - as the server tried to create the missing gzips and .jsons, and the database wasn't transferring more than 16KB per access before being disconnected. The solution is to identify and delete the corrupt files.

Four of the top ten styles are corrupt [screenshot]. The .css files that are exactly 16KB (uncompressed) are truncated. The smaller files are unaffected, the larger files have been re-uploaded. For some styles [1] the .json file is smaller than the corresponding .css file. Those are almost certainly corrupt - it's not impossible, but they don't exist in the wild.

Justin Hindman said:
In the meantime I can answer some of your questions – the DB is secure, stable and backed up.

"Secure" as in, you checked styles that were reported as corrupted against the md5 in the database?

[1] https://userstyles.org/styles/68293/crunchyroll-dark-theme

calico · October 2016

Additionally, normally when clicking on "More themes" from the homepage, the newly posted styles come up first. Currently, the newest posted date when searching from there is Oct 6.

Andy Cormack · October 2016

hideheader said:

Andy Cormack said:
The search result, at least, seems to have fixed itself after some hours, not sure if that was some tinkering on your end in general or not?
No, it hasn't. The style in the original report [1] is still unfindable, the test style I updated on Oct 7 [2] is still unfindable, the new style I just created [3] is unfindable.

[1] https://forum.userstyles.org/discussion/51866/the-search-module-cant-find-the-themes-ive-created
[2] https://forum.userstyles.org/discussion/51866/the-search-module-cant-find-the-themes-ive-created#Comment_107421
[3] https://userstyles.org/styles/133663/simpler-test

I was replying to Justin specifically about my instance as it did indeed end up back in the search results, I didn't mean to imply that I'd tested everyone elses :)

R. Schneider · October 2016

CRITICAL: - Hindman, Barnabe or whoever has the capability MUST validate all UserStyles' CSS hosted on UserStyles.org, AND MAKE NOTIFICATION on EACH and EVERY PAGE having a corrupted UserStyle - both with a TEXT NOTICE describing the corruption issue, AND by DISABLING THE "INSTALL BUTTON" of corrupt userstyles - until after the UserStyles corruption issue has been resolved "totally" (see below).
      By the way, there is interesting background reporting about the Barnabe-to-Hindman ownership changeover, and the userstyles corruption issue (which directed my attention to this forum) in the Ghacks.net article at http://www.ghacks.net/2016/10/09/stylish-and-userstyles-org-have-a-new-owner/. I edited the most salient details, as well as the "anagrammer" revelation of the changeover's 16kB CSS file truncation, which is at the root of the userstyles corruption problem, in my PasteBin post at http://pastebin.com/wkXjTAea. The 16kB CSS file truncation breaks all UserStyles larger than this size, leading to corrupt files which won't install, and that in turn leads to users' stats no longer incementing with new install counts. So user stats not incrementing was a tertiary symptom, deriving from install failures, which derived from 16kB CSS file size truncation during Hindman's takeover. - Apparently, many userstyle authors WERE aware of their install counts not increasing, BUT THEY DIDN'T KNOW THEIR USERSTYLES WERE FAILING TO INSTALL FOR NEW USERS, BECAUSE THE USERSTYLE'S CSS WAS BEING CORRUPTED (truncated at about 16kB). This only affected userstyles whose CSS file was larger than 16kB, so smaller userstyles would still install and run properly.
      User "anagrammer" mentioned "validating styles" in one of his posts in this forum topic. I am not only seconding his suggestion, BUT MORE IMPORTANTLY, changing it from a suggestion to a MANDATORY OBLIGATION ON YOUR PART, Justin Hindman, since the actions you took in taking over UserStyles.org put in motion this massive failure. And it is a failure STILL UNKNOWN to most affected userstyles' authors AND users who try to install the broken userstyles. YOUR FAILURE, OR REFUSAL, TO VALIDATE ALL USERSTYLE CSS, AND MAKE IMMEDIATE AND PUBLIC NOTIFICATION ON EACH AFFECTED USERSTYLE'S INSTALL PAGE (AND DISABLING THE "INSTALL BUTTON"), WILL BE EVIDENCE OF MALPRACTICE ON YOUR PART. There is NO WAY to protect users, authors, and the reputation of UserStyles.org if these required actions are not taken immediately. Both of my most popular userstyles, "Black Google by Panos - R. Schneider Mod (Large)", and "Black Google by Panos - R. Schneider Mod (Medium)", were trashed in your takeover - and I did not know of it until today (almost two weeks after your failure - the installs dropped abruptly to "0" on 9/29/16, and remain there). How many users tried to install one of my userstyles (corrupted by you), and blame me for incompetence? I had 2062 installs of my Large version, and 554 installs of my Medium version, when the install counts stopped incrementing 9/29/16. By the way, "Black Google by Panos", the userstyle my two were derived from (correcting his errors), has almost 500,000 installs - a very popular userstyle, indeed - AND YOU BROKE HIS USERSTYLE, ALSO. He was getting 300-500 installs per week; I was getting around 50 - and now we are both down-and-out until we repost our userstyles. And it is quite possible that Panos Babo doesn't yet know you broke his userstyle, along with so many other authors. VALIDATION OF ALL USERSTYLES' CSS, no matter how laborious, is your ONLY way to get a handle on this - unless you already know how to RESTORE ALL CORRUPT USERSTYLE CSS FROM A VALID BACKUP - hopefully one made JUST BEFORE THE CHANGEOVER. (You were smart enough to make that backup, weren't you?) And if you have a backup, and don't yet know WHAT has to be restored, VALIDATING THE CSS OF ALL USERSTYLES is the ONLY way you are going to find out. DO IT !!!
      And if you DON'T have a way to restore the broken CSS of ALL corrupt userstyles, you MUST notify all affected authors that their userstyles are broken, and that they must repost the CSS. THAT IS IN ADDITION to placing a Text Notice on the Style page, and disabling the "Install Button" (which actions are REQUIRED to notify potential users, and prevent trashing the reputation of the userstyle's author, and Stylish).
      [By the way, authors reposting large userstyles have a major pain, since the CSS editor on UserStyles.org has about a 1024 character limit for Copy/Paste. - How stupid is that?]
      Incidently, I have been a huge fan of Jason Barnabe for MANY years, and praise his work and devotion highly on a page for a Greasemonkey UserScript of mine (https://greasyfork.org/en/scripts/12271-revert-to-google-s-old-2012-2015-favicon). This recent UserStyles.org failure (and a MASSIVE failure it is), is a major letdown. The ramifications of this problem will not only affect new users trying to install corrupt userstyles - but will very likely impact the reputation of UserStyles.org, Stylish, userstyles authors - and, of course, Justin Hindman - and for a LONG time, if it is not VERY QUICKLY resolved. The longer a fix takes (assuming a restore-from-backup can take care of ALL corrupt userstyles' truncated CSS), the more likely it is that an older backup restore will wipe out an author's new reposted userstyle that included changes or improvements. Somebody better bust their ass to fix this - NOW !!!

Justin Hindman · October 2016

Quick update - the main reason for all bugs you've raised is because I used the AWS migration service, which sucks and it's totally my bad...
Some of the tables where there was use of longtext got broken, which mostly effected the long styles. I've managed to restore most of the tables and you should see most styles working well again. Search seems to be working well too, which leaves the weekly install counts as the only main remaining issue. I'm still working on that.
Other than that, there are still some local problems with I'm dealing with, so I can't yet say all is back to normal yet, but we're definitely getting there.

It would be a big help if you could review your previous bugs and tell me if you're still seeing them.
Thanks

anagrammar · October 2016

Glad to see you follow through. The couple I had been checking for reference seem complete now. I am still seeing a bug though. I updated my styles after the transfer, so I kind of expected them to revert to what they were in your backup. I haven't been updating Stylish with the code I'm uploading because I don't trust the process currently. Anyway, clicking "show css" on one of mine returns an error:
https://userstyles.org/styles/133094/vk-aquatica-dark-redesigned-layout

phi · October 2016

Three styles of mine just vanished between yesterday and today. Is this related to the migration?

calico · October 2016

Looks like a bunch of missing styles between these two:

https://userstyles.org/styles/133515/google-search-solarized-dark
https://userstyles.org/styles/133516/sap-sdn

Sean Mayes · October 2016

Half of my styles have now completely disappeared from my account, should I re-upload or will they appear again at some point? glad I backed them up.

hideheader · October 2016

Justin Hindman said:
Some of the tables where there was use of longtext got broken, which mostly effected the long styles. I've managed to restore most of the tables...

Yesterday you said "the DB is secure, stable and backed up". Today that's not true. Was it not true yesterday as well?

Justin Hindman said:
... which mostly effected the long styles. I've managed to restore most of the tables and you should see most styles working well again.

Which styles are still broken? I'm expecting something definitive, like

SELECT style_id, short_description, md5 AS old, MD5(style_codes.code) AS new
  FROM styles JOIN style_codes ON styles.id = style_id
  WHERE old <> new

which should be a very short list, if what you say today is true.
https://github.com/stylish-userstyles/userstyles/blob/master/db/structure.sql

hideheader · October 2016

The test style I make yesterday (133663) is missing today, and an existing deleted style (126922) that I undeleted and updated yesterday is again deleted with the old metadata. Both were small, one-rule styles which reasonably should have been excluded from any targeted restore operation, so what exactly did you restore, @"Justin Hindman"?

I undeleted and modified the metadata of that old style (126922) again today but Sphinx can't find it. I also created a new style (133566) today, and Sphinx can't find that either.

calico女 said:
Looks like a bunch of missing styles between these two:

You lost me there. I can see both styles, and 133516 immediately follows 133515, so what's missing?

Dante_MS · October 2016

My style has fixed, thanks, but it looks like updating of styles doesn't work in Chrome and Opera.
It says "Update completed", but code of the style remains old. Stylish is finding new updates over and over, but can't install them.
In Firefox and Safari everything works well.

Howdy, Stranger!

Categories

Bug Alert

Comments

Howdy, Stranger!

Quick Links

Categories

Bug Alert

Comments