Posted By: Jason Barnabe (np)Has anyone seen the edit dialog not opening bug in a nightly? I'm trying to see if this is something that's been fixed in Firefox (and if so, the Bugzilla bug) so I can inform the author of It's All Text!.
Using current trunk nightlies I don't get this bug. The edit dialog always opens. I do see the "Edit dialog is too small" bug but after resizing it maintains the size. I don't have IAT installed.
Posted By: Jason Barnabe (np)There are already ways of getting most of those things to happen... Delete by pressing Delete, Edit by double clicking on a line, Write by double clicking on an empty spot, Help by pressing F1.
not terribly discoverable, and not all would work for us mousers..
Posted By: Jason Barnabe (np)It looks like this only happens when It's All Text! isn't installed. I'm going to have to look more into it, but it looks like a Firefox bug.
yep, installing IAT eliminates the problem. and it's not too bad either.
As long as you're adding support for other extensions, why not have the color picker use Rainbowpicker if a user has it installed Preview I use it all the time and it's great!
I assume IAT will not be required to be installed (of course we all know what happens when you assume) :)
Posted By: Jason Barnabe (np)There are already ways of getting most of those things to happen... Delete by pressing Delete, Edit by double clicking on a line, Write by double clicking on an empty spot, Help by pressing F1.
not terribly discoverable, and not all would work for us mousers..
Also, sometimes peole are lazy to switch between mouse and keyboard. I myself use the buttons' accesskeys to write (alt-W), edit (alt-E), and delete (alt-D) from my left hand on the left hand side of keyboard while my right hand is on the mouse.
Speaking of accesskey, please also add accesskeys to Save (alt-S) and Preview (alt-w) buttons on the edit window, thanks.
Those of you with the It's All Text/edit dialog problem... In the profile/version that doesn't work, if you set nglayout.debug.disable_xul_cache to true, does it work? In the profile/version that does work, if you set nglayout.debug.disable_xul_cache to false does it stop working?
I had the problem opening the editor a second time (IAT not installed). Adding [ nglayout.debug.disable_xul_cache = true ] to about:config solved the problem.
Posted By: dougeeebearI had the problem opening the editor a second time (IAT not installed). Adding [ nglayout.debug.disable_xul_cache = true ] to about:config solved the problem.
I'm still getting the following error console message though:
No chrome package registered for chrome://itsalltext/content/API.js .
When creating a new style, "[v] Enabled" is not displayed. Is that intended behavior? I don't always want a new style automatically enabled because I might not have it finished yet.
Posted By: ValacarSo is nglayout.debug.disable_xul_cache set to true a temporary work-around for the bug?
Yes, emphasis on "temporary". You could also install IAT.
Posted By: Valacarwhat's left to do before 0.5 is out of alpha?
A bunch of things suggested in this thread and the "Suggestions" thread are already done. The things left include a DOMI overlay (maybe Firebug too), easy submitting to userstyles.org, data URIs for XBL, and Thunderbird and Mozilla Suite support. I don't do alphas/betas like Mozilla does. Once it's in beta it pretty much means no new features. There's going to be a second alpha soon.
Posted By: ValacarI found one bug with the search box though...if you type in something that won't match any styles like "sadfkjhsa", it will say that I have no styles installed and that I should visit userstyles.org.
I should change it to only give that message if there are no styles AND the filter is blank.
I simply changed mine to read: "There are no styles installed that match your search criteria. Hit Backspace to go back."
BTW, the search feature is great, as is all of 0.5. Great work!!
Posted By: alta88could you give #hide-tree > vbox > hbox (the search box) an id? this way i can move it onto the toolbar and save a lot of space.
although i could actually do the above without an id (using a lot of firstChilds), i can't figure out at all how to access the xul:hbox 'child' of the Edit window's dialog#stylish (to move the Save button row up to the Insert row). can you make it accessible via js? or does someone know a way?
other thing is i'd like to open the Editor, loaded with a particular style, in a tab or Split Browser pane. chrome://stylish/content/edit.xul loads fine for New, but i couldn't see a way in the code to easily pass a style, ie some sort of ?stylename. goal is to add ondrag to a list item and drag it to a tab or pane..
I've done a lot of things suggested in this thread and in the suggestions thread without saying I would. Adding an ID to a search box and Split Browser support (which also works on tabs!) are two of them.
dougeeebear, if you dislike multiple layered windows, like it seems, you've gotta try Split Browser. i wish it were part of Core, so extensions could handle those windows cleanly. and down with that always left side and vertical sidebar thing. ;)
Posted By: Jason Barnabe (np)Those of you with the It's All Text/edit dialog problem... In the profile/version that doesn't work, if you set nglayout.debug.disable_xul_cache to true, does it work? In the profile/version that does work, if you set nglayout.debug.disable_xul_cache to false does it stop working?
Sorry, I wasn't able to reply earlier.
On Firefox trunk, setting nglayout.debug.disable_xul_cache to false does not cause the dialog to stop working. I partly tested when the dialog started working correctly: sometime between 2005-08-15 (just after branch for 1.8) and 2006-01-06. I'm happy to narrow this range if you think it will help you fix the problem when using Stylish with Fx2.
To clarify, this is with Stylish installed in a clean profile and IAT not installed.
Thanks. It sounds like it was a bug that was fixed on trunk and probably has no chance of landing on the branch. I got a workaround from the author of It's All Text which should work in all cases.
Can someone with a Firefox alpha or nightly test this on Windows: go to View -> Page Style, make sure Stylish entries are there. Then open the Customize Toolbar dialog, close it, and check View -> Page Style again. Are the Stylish entries still there? On 2.0, they're gone.
Posted By: Jason Barnabe (np)Can someone with a Firefox alpha or nightly test this on Windows: go to View -> Page Style, make sure Stylish entries are there. Then open the Customize Toolbar dialog, close it, and check View -> Page Style again. Are the Stylish entries still there? On 2.0, they're gone.
With current nightly and Stylish 0.5a the Stylish entries are still there. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070315 Minefield/3.0a3pre ID:2007031504 [cairo]
No problems on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070315 Minefield/3.0a3pre...entries are still there. I also tried it first with my two day old update (20070313) with the same results.
Narrowed this down a bit: 3.0a1-2006-08-15-04-trunk FAILS 3.0a1-2006-08-16-04-trunk WORKS
that puts Bug 348016 – The "Recently closed tabs" menu is no longer functional after opening the "Customize toolbars" dialogue in the window, but looking at the patch I really don't see how it could have fixed this. In any case it certainly is a very similar problem
Posted By: Wildmyronthat putsBug 348016– The "Recently closed tabs" menu is no longer functional after opening the "Customize toolbars" dialoguein the window, but looking at the patch I really don't see how it could have fixed this. In any case it certainly is a very similar problem
That's exactly the same problem in this case, but they worked around it by switching from event listeners to oncommand rather than fixing the root cause.
Comments
I use it all the time and it's great!
I assume IAT will not be required to be installed (of course we all know what happens when you assume) :)
I'm using Firefox 1.5
Speaking of accesskey, please also add accesskeys to Save (alt-S) and Preview (alt-w) buttons on the edit window, thanks.
thanks.
Adding [ nglayout.debug.disable_xul_cache = true ] to about:config solved the problem.
No chrome package registered for chrome://itsalltext/content/API.js .
Is that intended behavior?
I don't always want a new style automatically enabled because I might not have it finished yet.
Also, just wondering...what's left to do before 0.5 is out of alpha?
"There are no styles installed that match your search criteria. Hit Backspace to go back."
BTW, the search feature is great, as is all of 0.5.
Great work!!
other thing is i'd like to open the Editor, loaded with a particular style, in a tab or Split Browser pane. chrome://stylish/content/edit.xul loads fine for New, but i couldn't see a way in the code to easily pass a style, ie some sort of ?stylename. goal is to add ondrag to a list item and drag it to a tab or pane..
An option to always open the editor in a new tab would be awesome!
dougeeebear, if you dislike multiple layered windows, like it seems, you've gotta try Split Browser. i wish it were part of Core, so extensions could handle those windows cleanly. and down with that always left side and vertical sidebar thing. ;)
On Firefox trunk, setting nglayout.debug.disable_xul_cache to false does not cause the dialog to stop working. I partly tested when the dialog started working correctly: sometime between 2005-08-15 (just after branch for 1.8) and 2006-01-06. I'm happy to narrow this range if you think it will help you fix the problem when using Stylish with Fx2.
To clarify, this is with Stylish installed in a clean profile and IAT not installed.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070315 Minefield/3.0a3pre ID:2007031504 [cairo]
Doesn't work with 2006-01-04-06-trunk build
3.0a1-2006-08-15-04-trunk FAILS
3.0a1-2006-08-16-04-trunk WORKS
that puts Bug 348016 – The "Recently closed tabs" menu is no longer functional after opening the "Customize toolbars" dialogue in the window, but looking at the patch I really don't see how it could have fixed this. In any case it certainly is a very similar problem
Edit: narrowed date range further