Stylish-Custom

1232426282981

Comments

  • Yes, i do have a bunch of stuff that seems to be related:

    Error: Components is not defined
    Source file: chrome://global/content/bindings/button.xml
    Line: 13
    ============
    return Components.interfaces.nsIAccessibleProvider.XULButton;

    --------------- " --------------
    Error: codeE is not defined
    Source file: chrome://stylish-custom/content/edit-overlay.js
    Line: 626
    =========
    doc.getElementById("css").value = codeE.value;

    -------------- " ---------------

    and a bunch of warnings:

    No chrome package registered for chrome://itsalltext/content/API.js

    No chrome package registered for chrome://diavolo/content/editor.js
    No chrome package registered for chrome://diavolo/content/editor.js
    No chrome package registered for chrome://diavolo/content/selector.js
    No chrome package registered for chrome://diavolo/content/grammar.js
    No chrome package registered for chrome://diavolo/content/highlighter.js
    No chrome package registered for chrome://diavolo/content/tokeniser.js
    No chrome package registered for chrome://diavolo/content/codecompletion.js
  • No chrome package registered for chrome://itsalltext/content/API.js
    sounds like iat it missing
    Error: codeE is not defined
    Source file: chrome://stylish-custom/content/edit-overlay.js
    Line: 626
    =========
    doc.getElementById("css").value = codeE.value;
    oops
  • Stylish-Custom-0.6.8.xpi
    page button wasn't working right
    right-clicking external edit/page won't show the customize menu anymore
  • Here's a pic with 0.6.8
    You can see the differences... the row containing page an !important -buttons is a wee bit too high, but thats fixable. Any ideas on how to further make the edit-window's buttons look like tat clear search -button seen there?
  • look in Profile\\extensions\\nasanightlaunch@example.com\\chrome\\global for button.css and toolbarbutton.css
    post what you come up with and i'll add it to the style i apply for nasa
  • I've taken the whole button.css and converted them images:) Will need to check the toolbarbutton.css too, had forgotten about that.
  • ChoGGi: You've a new PM waiting @ mozine
  • Thanks!
    Ext. editor is still not working. No errors, the same warnings as posted above. But the Page seems to be working - tried 5 times and it worked 5 times! Awesome!
  • edited January 2010
    makondo ! My Hero ! To the rescue
    Thankyou SO MUCH for figuring out the cause of ALL the malfunctioning SAVE BUTTONS (ESPECIALLY the fabulous Save ENABLED and Save DISABLED). Yup, it was the ENABLED CHECKBOX that I had placed back into the customized toolbarbutton window. I guess ChoGGi explained something about hiding unwanted toolbarbuttons ,but I didn't quite catch it. I spent a lot of time trying to figure it out and thought I never would. You saved me even more wasted time on it. hurry up

    ChoGGi ! WOW! I love the new Save Enabled/Save Disabled Buttons. So much easier and better. EXCELLENT ! Thankyou Thankyou Thankyou SO MUCH for creating them! They're PERFECT!!

    #1 The Findbar with the Next/Pevious arrows appears now (as well as the other findbar).Version 6.6 . I don't know why it does now and didn't before though. What about combining the 2 findbars where the Next/Pevious arrows findbar has a clear button, or the clear button findbar includes Next/Pevious arrows. I see no point in having 2, it means having to style 2 different findbars instead of 1, and each findbar is missing a feature (either clear button or Next/Pevious arrows).

    #2 I see a problem with the Preview/Un-Preview Buttons. There is a HUGE jump and SHIFTING whenever the Un-Preview button Appears/Disappears. When the editor window is opened wide,the button to the right of the Un-Previw button moves out of the way to the right to allow for the appearance of the Un-Preview Button, and then moves back into place to the left when the Un-Preview Buttons disappears. And when the window is NOT OPENED VERY WIDE,(which I do sometimes to have more browser webpage viewing space), then all the buttons to the right of the Un-Preview Button SHIFT.
    I tried putting 3 spaces (from customized toolbarbutton window) between the Un-Preview Button and whatever Button is Placed to the right of it. It doesn't prevent the Jump/Shifting. I use the Un-Preview button A LOT when testing measurement etc..

    So to solve it, I think the Un-Preview button needs to keep it's empty space in place when it disappears.

    Like when you use display:none or visibility:collapse it removes the empty space, but opacity:0 does not remove the space, but visibility:hidden can sometimes keep the space and if you click in that empty space there will be no reaction like you would with opacity:0

    What can I do to stop this very disrupting JUMP/SHIFT ? Or is there something that you could change please ??? Thankyou!
  • edited January 2010
    Oh well, I cannot seem to customize anything. When I try to drag some button to the customize window, the window focus just changes. Seemingly no errors pop up in the console either.
  • edited January 2010
    ChoGGi,
    found something else.
    When you post a style and paste its address in the URL bar, the 'update' checkbox doesn't show. Instead of just clicking Save, as it used to be, i now have to Save and Close. Then i reopen the style, and only then the update checkbox shows and i can uncheck it/Save again.

    Barbie,
    you're welcome!

    I don't have a huge space/jump. I actually happen to like that it hides and appears. Thanks to your style, i made a couple of nice icons and it looks pretty great, if i may say so myself Thank you!. I have it to the left of the find bar and it works well. It moves the find bar a bit but since there's nothing after the bar but a flex space, it doesn't matter, just take a look here. Of course, this is just a temp solution, i agree, it needs its own space even when not shown.

    DMCrimson, what do you mean?
  • edited January 2010
    @barbiergirl 1. i'll see about it
    2. try a flexible space or you could try something with #DisablePreview[style="display: none;"]{min-width:somesize!important}
    also you should be able to remove anything you want now (with 0.6.7+)

    @DMCrimson thanks i'll add it and for the customize problem, what version of stylish/ff do you use and are there any warnings/comments?

    @makondo i'll check out that update problem
    edit: seems to be working, when you type something in the url bar then click elsewhere it shows the update checkbox
  • edited January 2010
    ChoGGi: I'm using the latest versions, I think.
    Stylish 1.0.8beta (same happened with 1.07),
    Firefox 3.5.6
    (Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.1.6) Gecko/20091201 Firefox/3.5.6)

    and all I get in console that is related:
    Error: gToolbox is null
    Source file: chrome://global/content/customizeToolbar.js
    Line: 28
    (said line: gToolboxDocument = gToolbox.ownerDocument;)
  • edited January 2010
    hmm, something happened on posting that.
    Whats up with that funky wrapping? (Damn BBCode formatting)
  • Posted By: ChoGGiedit: seems to be working, when you type something in the url bar then click elsewhere it shows the update checkbox
    Not for me. I posted a style, copy/pasted its address in the URLbar/Save. It used to be that when you click Save, the update checkbox will popup right then and you uncheck it (if you don't need updates)/Save & Close, done. That doesn't work for me now. There no errors that i noticed though. I'll try later today with some other style.
  • Stylish-Custom-0.6.8.xpi
    Edit:
    added clear button for search boxes
    added tooltip for customize items
    shows the correct search box after customize
    Posted By: makondoNot for me. I posted a style, copy/pasted its address in the URLbar/Save. It used to be that when you click Save, the update checkbox will popup right then
    you just need to change the text then click something else to move the focus away for sc to do its thing
    try the above build and see if it fixes it
  • edited January 2010
    Thanks!
    No tooltip shows for the (still not working) external editor and for Insert.
    Don't know about the Clear button, there always was one in whatever searchbar i'm using wink (Options says 'old').

    The update checkbox seems to be working all right now. It seems that it changes on the spot now. Thanks, good job!

    We still have the external editor issue, in case you forgot. I don't have It's all text! installed and didn't change the Options setting. It simply doesn't work any more (but it works in .6.3!). I now moved every thing out to the toolbar which i hide. Still not working. And still no errors/warnings except for the one i posted above. It used to show my Notepad++ but it doesn't any more. It's set to SC and the path to the notepad++.exe is the same but the 'notepad++' doesn't show as it used to. Nothing shows at all. Now, if i Rclick/Customize, it appears on the toolbar in its place but as soon as i close the customize window, it's gone again. I tried moving it around onto diff. bars, but i get the same result - it only shows as 'external editor' when the Customize window is open.
  • edited January 2010
    This may be irrelevant now, but if all text-labeled buttons in the editor had tooltips (mouse-over text) with a longer description, there wouldn't be as much of a need for concise labeling. Mousing over a button would reveal its purpose in the tooltip instead of leaving the label up for interpretation (I'm looking at a previous version now, with a button labeled "Page," which I've never used, but accidentally clicked on 2 occasions).
  • Posted By: makondoit only shows as 'external editor' when the Customize window is open.
    external editor is the button for IAT, the SC one doesn't have a label (i should change that)
    look for a blank button in the customize box or maybe it's on your hidden bar
    Posted By: PlastikManiacThis may be irrelevantnow, but if all text-labeled buttons in the editor had tooltips (mouse-over text) with a longer description,
    alright
  • edited January 2010
    No, no and no. I have changed the option to both of them not once. There's no blank button and it's not in my customize window.
    It shows in the place i had it originally (and it still shows under .6.3 at that same spot) but only while the customize window is up. The second you close it, the icon is gone too. That happens only if i have SC external editor checked in the options. If i check IAT, it shows but is not working, clicking it does nothing.
    With .6.3 it's opposite: it shows as notepad++ if SC ext.editor is checked and it's working fine.

    EDIT: i stand corrected - there is a blank button in the customize window! What is it? If i drag it out, it disappears when the customize window is closed.
  • Labels for stylish custom's buttons in main browser window's customize popup are again on the side of the icon, and I still cannot get toolbar customization to work, maybe it's because it opens up as a separate window instead of a sheet that slides out of the titlebar on mac?
  • Stylish-Custom-0.6.8.xpi
    Edit:
    fixed some labels/issues with customize and dragging
    changed where the customize window opens
    added tooltips to everything
    Options:
    export settings wasn't saving auto!important settings
    re-export to save them

    @makondo see what happens now

    @DMCrimson try this and see what the two msg boxes say when you click customize
    Stylish-Custom-0.6.8-d.xpi
  • edited January 2010
    Shock
    Now we can't customize so i can't tell you what happens Laugh
    I saw the notepad++ (had to reset option to SC). It's working, thanks!!! But it's looking 'funny'. I can probably change that but would be nice to know what that means anyway. I'll post about it later, have to test some more.

    The problem now is with the customize window: it popped tow small dialog windows, something about js. Closed both, my flex spaces and the extra ext. editor button showed in the editor window but there's no way to drag anything anywhere since there's no customize window.

    Also. You changed the find bar to the one i don't like. Can i have the old one back, please Smile


    EDIT: NM. Had to reset the findbar to the old, again. It was changed. Please try not to do that. Extensions shouldn't change settings.
  • OK, the 'funny' look is the parenthesis. And because my code for the image no longer works and the ext.editor button is in the wrong place, it looked cut off and therefor 'funny'. NM that. When i'll be able to customize again, i'll move it. And will re-write the code for the image now.
  • edited January 2010
    Two new warnings:

    Warning: reference to undefined property window.arguments
    Source file: chrome://stylish-custom/content/edit-onload.js
    Line: 181
    =============
    if (window.arguments){


    Warning: reference to undefined property window.arguments
    Source file: chrome://stylish/content/edit.js
    Line: 57
    ==========
    if (window.arguments) {

    Oops, actually there's more. Just opened the manager from the addons manager:

    Warning: assignment to undeclared variable showView2
    Source file: chrome://stylish/content/manage-addons.js
    Line: 63
    =========
    showView2 = showView;
  • edited January 2010
    All right. Start laughin' now. Apparently, i clicked the wrong link, the bottom one, for DMCrimson. Those 2 small js popups must have come from there. Hmm...

    However, i still don't get the customize window. But i got an error:

    Error: gToolboxDocument.defaultView is null
    Source file: chrome://global/content/customizeToolbar.js
    Line: 144
    ===========
    if (!gToolboxChanged || gToolboxDocument.defaultView.closed)
    Posted By: ChoGGi...changed where the customize window opens...
    Mind to share? Hehe
  • guess i should have tried it on 3.6 :)
    Stylish-Custom-0.6.8.xpi
  • ROFL
    We are in business!! It's all working here!!
    Sorry i bug you with 3.6b5 but the final is coming out soon, as you know Yeap!

    Awesome job, ChoGGi, thank you!!
  • Posted By: ChoGGi
    @DMCrimson try this and see what the two msg boxes say when you click customize>
    the first one says "stylishCustomToolbox" of the latter I can see only "omToolbox", it's out of screen. When I dismiss them, customization window appears - and I cannot get rid of it via esc nor enter as should be with windows?
    The edit window retains all the buttons there, even those extra ones that appear when selecting "customize" , but "customize" is grayed out afterwards.
    These errors appear:
    Error: idTmp is null
    Source file: chrome://stylish-custom/content/customize-onload.js
    Line: 16
    Error: gToolbox is null
    Source file: chrome://global/content/customizeToolbar.js
    Line: 28


    This is with 0.6.8-d, I'll try tha later version now.
Sign In or Register to comment.