Stylish-Custom

1222325272881

Comments

  • edited December 2009
    HD=Hard drive Embarrassed
    OK, So in my head, I'm going to pretend that never happened. So embarrassed, I wanna hide
    So what's it going to cost me to get you to forget that one makondo and ChoGGi?

    So I just re-did my Stylish editor style and changed it for my new Stylish Custom Editor. ONLY works for 6.3 though. http://userstyles.org/styles/18502

    Stylish custom 6.4 and 6.5
    I love the new system for the bottom bar. The Dragging and spacing features. Fantastic! Thankyou!
    But... Nothing will save.
    Save
    Save%Close
    Save Enabled
    Save Disabled

    NONE OF THEM WILL SAVE NEWLY WRITTEN STYLES. They are gone forever.
    I click on any of the saves above, and check stylish sidebar to find them, and they are not there.
    I was also hoping that Save Enabled and Save Disabled buttons would:
    "Save Enable and close"
    and
    "Save Disable and close"
    But they do nothing at all right now.
    Thankyou for placing the buttons though!

    I also do not get the findbar with the arrows Next/Previous.
    I click for it in options (old), open a new editor, and only the findbar with the clear button is there. I go back to options, and it is radio checked for new.

    All my buttons are off center. I will be changing them anyways, and can center them myself though.
    With no other styles applied for the stylish editor:

    Haven't checked everything out yet. Thanks!
    FOR NOW: GOT TO GO
  • edited December 2009
    oops, i was just checking the save menu

    edit: if you customize the edit dialog then you won't be able to save till you re-open it

    edit2: see if this takes care of the save problem
    Stylish-Custom-0.6.6.xpi

    edit3: it now also fixes the new search thing barbiegirl noticed
    Posted By: BarbiegirlI also do not get the findbar with the arrows Next/Previous.
    I click for it in options (old), open a new editor, and only the findbar with the clear button is there. I go back to options, and it is radio checked for new.
    that's the new search not the old

    the off center thing might be from them being toolbarbuttons, i'll take a look and see if it can be fixed
  • edited December 2009
    OK, now you can't close it. And! it lost my style. Again. But this time it really lost it. Clicked Save and Close. Reopened to check. The style was saved. Clicked the editor to customize, the style disappeared from the editor. After that, i couldn't close it with he button, had to use the upper right window close and when re-opened - the style was still gone.

    I know they're toolbarbuttons, i already have a style to hide all that fat ;-) but it still looks bad, IMO, if you don't have a style. And labels are still off. I guess it takes on some of my style since Barbie's look exactly opposite.

    EDIT: it appears that the style was not gone but the code doesn't show in the editor! and the tab at the desktop taskbar is empty!

    image

    EDIT 2: if you move '!important' to the customize window, it becomes disabled. If drag it back, you have to set it again.
  • edited December 2009
    Barbie, that's what i reported above (the style disappearance). But then, when this happened again, i found it untagged at the bottom of my list (i sort by tags). It showed disabled but was actually applied! That was with .6.4
    .6.5 simply wipes codes off. It might be a glass style, of course, but i have no means of checking it since we can't save styles NoIdea


    This is a very ... spooky build ....
  • edited December 2009
    Hmm, ChoGGi, dunno what you've done, but now the buttons do not comply with the theme, but try to mimic OS-style...
    Some images to clarify:
    with 0.6.3
    with 0.6.5
  • @DMCrimson i was trying to make them not so toolbarbutton like, didn't work too well
    Stylish-Custom-0.6.6.xpi

    @makondo that blank window title means it needs something from stylish that was originally in the dialog (i seem to remember that happening). try leaving it as, restart firefox, open the console, then open and close a style
  • edited December 2009
    Error: style is null
    Source file: chrome://stylish/content/edit.js
    Line: 173
    ============
    style.setPreview(false);

    Error: wrapLinesE is null
    Source file: chrome://stylish/content/edit.js
    Line: 38
    ============
    wrapLinesE.checked = wrapLines;

    It seems to me that if you drag buttons to the customize window, they get disabled. Not that it explains the disappearance of the code.
  • not sure about the first error (never got it yet), but that second one means you need to re-add the wrap lines checkbox
  • edited December 2009
    Right. It looks like i have to add all those buttons (i don't need) back. Because if you drag them out to the customize window, they get disabled. Hope you'll be able to fix that. Otherwise it doesn't make much sense having the toolbarbuttons.
    I really don't like the text buttons as is now. C'mon, you're the icon guru, make 'em icons.

    Save enabled/save disabled do not work. As any of the save options either. Plus, as Barbie said, we were hoping for 'save enabled and close' kinda thing.
    And another thing. If a style doesn't have a tag, the tags bar used to still be there, just empty. Now the bar itself is there but not the input box. So, even if you'd want to tag it, you can't. Plus, it looks odd.
    Is it too late to go back to the way things were and forget the toolbarbuttons?
  • Right. It looks like i have to add all those buttons (i don't need) back. Because if you drag them out to the customize window, they get disabled. Hope you'll be able to fix that. Otherwise it doesn't make much sense having the toolbarbuttons.
    the idea was people can rearrange it as they please
    you could make a new toolbar and stick everything you don't want on it and hide it
    i think i could do something about it
    I really don't like the text buttons as is now. C'mon, you're the icon guru, make 'em icons.
    i've been adding icons for awhile now :)
    http://userstyles.org/styles/739
    Save enabled/save disabled do not work. As any of the save options either. Plus, as Barbie said, we were hoping for 'save enabled and close' kinda thing.
    i didn't name it close to keep the length down, but it does close it
    0.6.6 doesn't fix the save/close problem (so it actually saves it)?
    And another thing. If a style doesn't have a tag, the tags bar used to still be there, just empty. Now the bar itself is there but not the input box. So, even if you'd want to tag it, you can't. Plus, it looks odd.
    if you move the tag toolbar item it doesn't move the toolbar itself. you have to use the rightclick menu to hide that
    Is it too late to go back to the way things were and forget the toolbarbuttons?
    no it'd be easy enough to do
  • edited December 2009
    I downloaded the "Last link posting" for Version 6.6

    #1 ALL toolbarbuttons have NO BORDERS. I like buttons to click on, with borders, "text only" confuses me. There is the text of Name,Tags,Url and then also the toolbarbutton text. So you have to stop and determine if Name,Tags,Url is a button to click on or not.
    THIS IS WITHOUT ANY OTHER STYLES APPLIED TO STYLISH EDITOR:

    This fixes text back into buttons:
    #stylish toolbarbutton
    {-moz-appearance: button !important;}
    But then the text is misaligned again.

    #2 No change with the findbar. I can only get the findbar with the clear button. (only change is that the options shows radio check as new.)

    #3 None of the save buttons work. You click on any of them and nothing happens. I close or X out, and style is not saved in stylish sidebar... I looked everywhere.

    #4 If I preview the newly written style, it applies, then click any of the save buttons and nothing happens. Close and X out closes. Newly written style is not in stylish sidebar, BUT style is still applied and you have to do a firefox restart to shake it off.

    #5 I also like the very top bar to be the Name title bar and want the editor to look like my style
    http://userstyles.org/styles/18502
    I thinks it's best to have the closest access to all the tools, nearest the editor window. (like with composing emails). I do like the toolbarbutton dragging with spacing. Can we place bars in any order?
    I don't think -moz-ordinal-group works.

    #6 I can't color the Page toolbar like I did in
    http://userstyles.org/styles/18502
    #custom-tools
    but I can color the whole frame with
    #Toolbox
    But coloring sections helps me to quickly identify areas, so I'd like to do that.

    #7 Would like the TOOLBARS to be less height. The buttons, or toolbarbuttons prevent that.

    PS: My smiley that I previously posted with "Got To Go" was meant to mean that I have to go now (offline) cause I'm busy and I can't get back to the post that soon. So I hope you don't think I was being rude and saying that the version 6.4 "has got to go".
  • edited December 2009
    ChoGGi,
    i think you've missed my post above. I'll try again:

    1. yes, this probably will work (moving unused buttons to a toolbar and hide the toolbar). Not very 'elegant' - as some would say - solution though. And certainly not easily discoverable by an average user there. We're used to dragging icons from/to the toolbar and be done. If dragging a button i don't use out of the editor breaks the editor, it's not really expected behavior, agree?

    2. I know about the style and that's why i called you 'Icon Guru' Wink. But, i, for one, don't want any icons anywhere. I simply would like to have an option to show text or icons, just like the main customize does. And this would mean for you to create those Yeap!

    3. I understand the naming. The problem is those buttons do not work no matter how you call them. Styles do not get saved no matter which one of the now 5 save buttons you click. Clicking Save enabled/Save disabled does nothing: does not save a thing and does not close the editor.

    4. I don't want to hide the tag bar. I like it the way it was - the bar was always there (by my choice). The input field was always there too. Now only the bar is there, it's empty and there's no way to tag a thing even if i'd wanted to. Plus, as you'll see on the shot below, it doesn't show the tag even for a tagged style.

    5. That's good to know. As of now, .6.4 - .6.6 are not working builds here. I can't use stylish. At all.
    Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b5) Gecko/20091204 Firefox/3.6b5 - Build ID: 20091204143806
    Stylish 1.0.8, SC 0.6.6

    image
  • edited December 2009
    Barbie,
    they're toolbarbuttons and i'm sure you have a style for the toolbar buttons that shifts the label. As you could see above, mine runs out to the left. To add to it, my toolbarbuttons look perfectly fine, only the new ones in the Stylish editor are ... screwed.
    BTW, personally, i like them as is/was - w/out the fat toolbarbutton border/padding. You can style that if you need it.

    Just saw your new style for the editor icons - good job, thanks! The only problem is ... can't use it since styles don't save .... Sad But when ChoGGi will figure this one out, i'll play with it, thanks again!
  • edited December 2009
    new version of 0.6.6
    you should be able to remove any toolbar items you don't want. you need to open/close the customize window for it to take effect (able to save) and maybe restart ff if there's any errors in the console

    @makondo about the tag bar. not sure how you got rid of it, but you can reset the toolbars in the customize window (if you removed it then it should be in there)

    @barbiegirl the toolbar ids #insertToolbar,#pageToolbar,#nameToolbar,#tagsToolbar,#urlToolbar,#CodeToolbar,#bottomToolbar
    #5 you can't move the toolbars themselves, but you can move everything else (so if you wanted the name textbox at the top)

    edit: another new version of 0.6.6 (forgot about 1.0.8b)
  • Here's a pic with 0.6.6

    Thus I second barbie's thingy... How would I make them buttons look like buttons?
  • edited December 2009
    ? ChoGGi, did you forget xpi?

    Anyway. Don't know why you're not getting it.... Let's try again. I can't remove any item i want because as soon as i do, they become disabled and screw the editor (remember the removing of the wrap ^?). Remove '!important;' and it becomes disabled - it will not work. The thing is, i don't know why it's there anyway. The option is set in the Options dialog. So, all that's needed is a button to actually insert it not the one to enable/disable the function ... if you know what i mean ;-).
    Yes, i do close the Customize window. You have to, it's one of those 'dead on top of everything windows' - you can't do anything until you close it.

    But the biggest problem is that i can't use Stylish at all if it doesn't save the styles!

    EDIT: just noticed, the external editor button is gone too. It's not in the customize or any bar.
    EDIT 2: I got the tag field back - was my style after all but i don't remember display:none it! Doh

    DMCrimson,
    Barbie posted a style to change those toolbarbuttons. Since you can't save styles with .6.6, install it with .6.3.
  • Oh, when I install from a link posted here, it informs that the size is 4Gb:D
    Posted By: makondo? Since you can't save styles with .6.6, install it with .6.3.
    Installed and saved fine here:D
  • edited January 2010
    Huh? You can save styles with .6.6? Barbie and i can't, as you can see above. What stylish version are you using, 1.0.8?
  • edited December 2009
    Posted By: DMCrimsonHere's a pic with0.6.6 Thus I second barbie's thingy... How would I make them buttons look like buttons?
    i could change them back, but the buttons will look like that screenshot you posted before
    toolbarbutton{-moz-appearance:button!important}
    Oh, when I install from a link posted here, it informs that the size is 4Gb:D
    it shows the xpi as 4gb?
    Posted By: makondo? ChoGGi, did you forget xpi?
    same link as before
    Stylish-Custom-0.6.6.xpi
    Anyway. Don't know why you're not getting it.... Let's try again. I can't remove any item i want because as soon as i do, they become disabled and screw the editor (remember the removing of the wrap ^?). Remove '!important;' and it becomes disabled
    what do you mean disabled?
    when you drag them to the customize window it removes them from the edit dialog, so if stylish tries to do something with it then it gives an error and doesn't process whatever code is left (like saving or closing)
    i added fake elements so it should be ok now (removing the find bar still gives an error, but it's the last bit of code so it shouldn't be a problem)
    I did not touch the tag bar. It simply disappeared. If needed, i can post pics of the same editor w/.6.3 and w/6.6.
    did resetting help at all?
    Huh? You can save styles with .6.6? Barbie and can', as you can see above. What stylish version are you using, 1.0.8?
    i can save them too, tried on 1.0.7/1.0.8 and ff 3/3.5.6/3.6b5
    also tried messing around with customize before i save
    try the new xpi and do the customize thing i mentioned in my last post
  • Forget the tags, i found a bit of code from long ago, when i wasn't use it, to hide it. It suddenly popped up .... i can't explain that one! Anyway, the tags are fine now.
    However, i still can't save any styles. I open a style for editing (a test kinda), change something there, Save & Close, as i used to. Re-open - the change is not saved, the style appears the same as before the changes. Or, i install a style from the site, Save enabled, click Close ( i hate that part. Save enabled/Save disabled should also close it but it doesn't). The style simply doesn't show anywhere but is applied. Restart Fx. Style is not applied any longer and doesn't show anywhere.
    Just like what Barbie says she's experiencing.
    I have the same with that last link.
  • ChoGGi: yes, 4 gigabytes:P Huge extension, eh? I just wonder, how I could make them buttons plain buttons. I could try to Nasafy them, I've done so to few toolbarbuttons that didn't behave.
    So, the main reason why they look like they do, is that they're toolbarbuttons instead of plain buttons?
  • edited December 2009
    Interesting. I'm posting from another profile and it works here... It's gonna be a long night since i have no idea if it's one of my ... 120 styles or 30+ exts.
    See you at Fx 4, i guess! Doh
  • edited December 2009
    Well, disabled all exts. - nothing. Disabled tag groups one by one, nothing. It just doesn't work. So, what's left is some user pref? ....
    I wonder what do we have in common with Barbie that prevents this version from working. I have no problem with .6.3. And that's where i'm going till 3.7 final. I'll do a clean install than.

    Still wonder what the problem might be - installed stylish 1.0.8 and SC 0.6.4 at about the same time - something has changed in one or both that prevents .6.4+ from working under the same conditions .6.3 does fine.
  • Well, ChoGGi, i found what caused the problem. When .6.4 came out, i got very excited and immidiately dragged/dropped all those (unneccessery any longer, as i thought) 'old' buttons. That is wrap, !important; with that extra bar box and enable/disable. While i than had to put some of them back, i forgot about enable/disable (with the checkbox). It appears that all this stuff still has to be shown or, as you have suggested, put on a toolbar which you can then hide. A bit of a run around, if you'd ask me.
    In any case, It was the disable/enable that prevented styles from being saved, as strange as it might sound to you.
    Here's the error i got which lead me to this ingenious discovery ( i made on my way to a NY party):

    Error: document.getElementById("ToggleEnabled") is null
    Source file: chrome://stylish-custom/content/edit-overlay.js
    Line: 831
    ==========
    if (document.getElementById("ToggleEnabled").checked == true){

    So, i suppose all's well now and i'm offff to make some noise!! Happy New Year!

    Excited image Yay!
  • :) might be a bit late for it now, but you should be able to hide anything now. hiding the search gives an error in the console, but saving still works

    Stylish-Custom-0.6.7.xpi
    Edit:
    found a couple other things giving errors when removed
    should restore everything that gets reset after customize
    Info:
    it was toggling styles for any key instead of only space (forgot about that part)
    deleting a style keeps selection
  • Thanks!
    I have all the stuff i don't need to see on the tag bar and hidden (i moved the tag bar to the name bar). This is awesome!
    But there's a problem with the external editor button, it doesn't work.
  • edited January 2010
    seems to be ok here, are you using IAT or SC?

    edit:
    Stylish-Custom-0.6.7.xpi
    error listing changed to a textbox instead of labels

    @makondo i think i figured out why the info search was acting weird, it does regexp searching (it was that or case sensitive)
  • edited January 2010
    Thanks for the update, i like it!

    I tried checking both. If i check SC, the ext.editor button doesn't show at all, which is normal. If i check IAT, it shows but clicking it does nothing. Unfortunately, there no errors to report.

    EDIT: One more thing. I put the Page button to the left of the URL bar. Now, whenever i Rclick the Page button, it not only takes me to the style' edit page but it also drops the Rclick context menu. Do you think there's a way to not show the context menu if the Rclick is on a button, no matter where the button might be?
    TIA!
  • I tried checking both. If i check SC, the ext.editor button doesn't show at all, which is normal. If i check IAT, it shows but clicking it does nothing. Unfortunately, there no errors to report.
    does iat work with other stuff?
    in the console try showing warnings and comments if you haven't (iat may catch the error and show it as something else)
    EDIT: One more thing. I put the Page button to the left of the URL bar. Now, whenever i Rclick the Page button, it not only takes me to the style' edit page but it also drops the Rclick context menu. Do you think there's a way to not show the context menu if the Rclick is on a button, no matter where the button might be?
    it shows it at the top too (forgot to fix that)
  • What 'other stuff', ChoGGi? Everything seems to be working all right except for the ext.editor button (well, the Rclick on the Page button still fails probably 85% of the time and i can't figure the conditions as it fails if a style is edited and closed than re-opened and Rclick takes you to the style page but the changes don't show. It fails if you Rclick it while editing and saving but not close the style .... I don't know, can't figure this. I copy/paste edited styles just in case).
    Anyway, i'm not sure i understand what you're asking, sorry.
Sign In or Register to comment.