Stylish-Custom-0.0.5.xpi add a button to merge lines (it removes line feeds/carriage returns from selected text) added an option to change what shows up when you press the auto!important key rearranged options dialog fixed a little auto!important key reset bug
found a forum post to figure out the problem of focusing on textboxes so fixed issues with search/inserting focus (woohoo) changed the default auto!important key to !
edit:did a quick update to also fix focus when you insert a colour (the server logs say someone downloaded it already)
Man! Now you need an Undo button for that Merge! Thanks for the update, looks good to me. ChoGGi, .... yes, another request! Do you think it might be possible to make it work with Rainbowpicker (or any extended 'normal' color palette)? TIA!
EDIT: ^ yeap, that was me. Nobody else seems to be around right now ;-)
You're just awesome, 'dear' ChoGGi! May i suggest one tiny thing, please? I think it might make more sense if Save&Close is next to Save and Preview/Un-Preview are together. Doesn't really matter up or down, just grouped together.
May i suggest one tiny thing, please? I think it might make more sense if Save&Close is next to Save and Preview/Un-Preview are together. Doesn't really matter up or down, just grouped together.
it should be doable, just need to figure out how to remove elements, then add a fake bottom bar (only so many buttons you can normally use for that area)
ChoGGi, i might be wrong but didn't !important used to have semicolon at the end? I think when you had the default set to ';', it would actually put '!important;' (with semicolon). If i'm wrong, do you know how i can do this (i use semicolon and now have to type it in, especially if it's not the last thing in a string). TIA!
Posted By: ChoGGii added a readme, but not like anyone is going to read it :)
Promised: I will read it!
Posted By: makondoMan! Now you need an Undo button for that Merge!
Posted By: makondoYou're just awesome, 'dear' ChoGGi!
+1 for that - 100% agree!
Posted By: makondoBut i don't suggest adding any buttons. It's the same count just switch places Un-Preview > Down, Save&Close > Up.
I just remember from the old thread that it was not that easy to achive - something with "limited amount of buttons that could go to that place" (like FF only accepts two buttons there). I suggested this as well some days ago, since it seems more logical. But it looks like ChoGGi already found a way of working around it with a "fake" button bar. Just let's wait and see. As far as my experience goes, he will come up with 0.0.7 as soon as I installed 0.0.6 and restarted my browser - so I will do so now
I had always thought this was a customized alternative to Stylish, not an extension to it, so I wish I had tried it earlier. Anyway, this is my first try so I'll give you my opinion on everything...
1: Status bar icon. The Disable/Restore buttons appear to do exactly the same as the Stylish native Turn All Styles On/Off option. Now these options are pretty useful when using the editor, but they're not needed in the status bar. Also, the Options menu item is already embedded in the Stylish menu... So after that, I see no need to have a second status bar icon at all (I know it can be turned off, but still...)
2: Disable/Restore buttons could be merged together to become a toggle button?
3: The Toggle button: perhaps that can be called 'Toolbar' instead as that better described what it does. Bonus points for moving the button one item to the left so it is grouped with all the other buttons.
4: Tools > Color would probably be better placed under the Insert menu since it inserts something. Maybe the same applies to Site Rules
5: Page button - I didn't understand what that meant and couldn't decypher the title either. Perhaps call it New Style, and have the title "Open a new window to create a new style on userstyles.org".
6: Didn't understand what Merge was supposed to to either, until I tried it. A better description would be "Merge several lines of code into one by removing line breaks".
7: Uncomment: removes every instance of /* and */ in the selected text - not just matching pairs, but that's not a major issue.
8: Search: when searching, it always highlights one too many characters i.e. the character immediately following the match is also included. Nice to see that F3 goes to the next match, though! (Perhaps make the search box a little wider, since the style title doesn't have to be that big).
9: !important button: should probably mention in the title that it adds !important to everything.
10: The auto-important feature: there are big issues here. If I delete the contents of the textbox, the backspace key becomes the !important hotkey which is unexpected. Even worse, typing a non-printing keystroke like Delete or F8 into the box when it's empty, and then using that hotkey in the editor, will cause the editor to go into an infinite !important loop, and completely lock up Firefox. Hence I had to rewrite this entire review. :(
If there's a feature that I didn't comment on, I probably missed it. ;)
Taking all that into account, good job on this. The extra features are useful, and it's good to see that every command can be undone too! I have one suggestion: line numbers (I know, I can use my own editor... but if it's possible then it would be cool) or when getting errors, click the error go jump to that line in the code.
I had always thought this was a customized alternative to Stylish, not an extension to it
it was an alternative then i made it an extension
1. turn off styles doesn't let you work on other styles while it's off 2. i'll see about it 3. yeah that sounds better 4. i've been trying to do that by adding the menuitems, i may have to hide that menu and add another 5. it either opens the style page or opens the add new style page depending on how the style was added to stylish 6. done 7. yeah i know, but i don't know how not to remove the extra comments 8. i'll see about the extra char and made the size 25 instead of 10 9. added that to the tooltip 10. don't delete it, just disable it (i'll see about disabling certain keys)
line numbers (I know, I can use my own editor... but if it's possible then it would be cool) or when getting errors, click the error go jump to that line in the code.
i believe np is adding line numbers to the next version of stylish, jump to errors would be nice to have though so i'll see about that also
edit: if you want to make a different icon for the manage window that would be nice :) (i have a bit of trouble noticing it with a dark background)
1: Ah... That makes a lot of sense. 4: I don't know a lot about XUL, but I know you can use XUL Overlays to add items to existing elements by using merging points. Some kind of attribute like insert-after or insert-before should allow you to specify its position relative to the ID of a sibling. 5: Sounds like it might be best to have two buttons, then - dependent on whether the style has an update URL on us.o already. 7: You can use a regex pattern match such as /\*[\s\S]*?\*/ (match an opening /* and zero or more characters (as little as possible), ending with a closing */) 10: Of course that's the sensible way to do it, but I was in testing mode. ;) Hopefully it won't be possible to crash FF in the future!
So, the icon? Requests welcome, but if it's going to be for one or several of the standard Stylish windows it's probably best to use the ones I already made.
4. yeah that was the plan (found out about it yesterday), haven't gotten around to it yet though 7. thanks
i was thinking that new stylish icon you did for the edit dialogs and for the manage something different (no biggie though, i'll probably stick with the original)
Honestly, I'm not trying to be lazy here! I think consistency with the icons is the best option, especially since the window icons are only 16x16 anyway with little scope for modifications that anyone would notice.
Stylish-Custom-0.0.9.xpi stopped the hide toggle for preview/unpreview added an option to change edit area font little bug with findbox and r renamed Toggle to Toolbar changed Merge/!important tooltip changed UnComment to only remove comments from start/end removed tools menu moved pick sites/insert color to the insert menu blocked from using some invalid keys for auto!important find was selecting an extra char on the end find wasn't going grey on focus and changed not found to red a new icon for edit dialog (thanks BoffinbraiN and for the suggestions)
Posted By: BoffinbraiNHonestly, I'm not trying to be lazy here!
:) i know just figured i'd see if you had one to use
ChoGGi, thanks for the update! Especially for separating Preview/Unpreview buttons. I came to ask you for that one - it was a bit inconvenient clicking Unpreview twice to get back to Preview. Do you think it might be possible to just have the Toolbar extended by default instead of toggling it on/off? TIA!
Good job! The preview/unpreview feature gets a big thumbs up from me and all the toolbars look tidier. Here are a few more observations:
1: When I disable auto !important and then type a new keystroke into the box, auto !important is enabled again immediately even though the box is not ticked. 2: The uncomment button isn't behaving very well. It only removes a comment if the selection ends with a */, otherwise it only removes the first /* and nothing else. If you're using replace() with a regex, I'll have a guess and say the solution might be to make it a global find-and-replace, and also make sure there's no end-of-string ^ or $ in the regex. 3: It's nice to have an icon that stands out on the editor windows again. :) Feel free to change the icon for the Options window and the Stylish standalone window, and the extension icon, for consistency. 4: Are we still going to keep the Custom status bar menu? As I said before, all the options it provides are available in the Stylish status bar menu.
1. whoops 2. yea there's a $, i'll see about some different regexp 3. i like the different icons for different windows (an option to change might be a bit tricky, my js I/O needs a bit of work) 4. yep, i don't usually use the enable/disable rules (don't want it to clutter up the regular menu)
Comments
add a button to merge lines (it removes line feeds/carriage returns from selected text)
added an option to change what shows up when you press the auto!important key
rearranged options dialog
fixed a little auto!important key reset bug
found a forum post to figure out the problem of focusing on textboxes
so fixed issues with search/inserting focus (woohoo)
changed the default auto!important key to !
edit:did a quick update to also fix focus when you insert a colour (the server logs say someone downloaded it already)
Thanks for the update, looks good to me.
ChoGGi, .... yes, another request! Do you think it might be possible to make it work with Rainbowpicker (or any extended 'normal' color palette)? TIA!
EDIT: ^ yeap, that was me. Nobody else seems to be around right now ;-)
re-added support for rainbowpicker
changed No Preview to Un-Preview
@makondo nope somebody else is around, but they must be the quiet type :)
May i suggest one tiny thing, please? I think it might make more sense if Save&Close is next to Save and Preview/Un-Preview are together. Doesn't really matter up or down, just grouped together.
Why isn't there a Donate button in your styles?
The only thing left to nag Jason about is selective Export/Import ...
TIA!
if you goto the options you can add a ; to the end
just noticed i made a booboo for the insert important function, it'll be fixed in 0.0.6 (just as soon i figure out some things for moving the buttons)
moved save & close to the right of save
moved un-preview next to preview (and toggles display of)
had a bit of trouble with hiding the switch to install button, so no switching back to install mode (you can switch to edit mode good enough for me) ctrl+z :)
Now... if only you could add ....
Kidding!!
(of course, i still have the selective Export/Import on my wishlist but i guess we'll have to wait for Jason to warm up to it)
restored window/dialog icons (used old icon for edit dialog and new icon for manage standalone)
1: Status bar icon. The Disable/Restore buttons appear to do exactly the same as the Stylish native Turn All Styles On/Off option. Now these options are pretty useful when using the editor, but they're not needed in the status bar. Also, the Options menu item is already embedded in the Stylish menu... So after that, I see no need to have a second status bar icon at all (I know it can be turned off, but still...)
2: Disable/Restore buttons could be merged together to become a toggle button?
3: The Toggle button: perhaps that can be called 'Toolbar' instead as that better described what it does. Bonus points for moving the button one item to the left so it is grouped with all the other buttons.
4: Tools > Color would probably be better placed under the Insert menu since it inserts something. Maybe the same applies to Site Rules
5: Page button - I didn't understand what that meant and couldn't decypher the title either. Perhaps call it New Style, and have the title "Open a new window to create a new style on userstyles.org".
6: Didn't understand what Merge was supposed to to either, until I tried it. A better description would be "Merge several lines of code into one by removing line breaks".
7: Uncomment: removes every instance of /* and */ in the selected text - not just matching pairs, but that's not a major issue.
8: Search: when searching, it always highlights one too many characters i.e. the character immediately following the match is also included. Nice to see that F3 goes to the next match, though! (Perhaps make the search box a little wider, since the style title doesn't have to be that big).
9: !important button: should probably mention in the title that it adds !important to everything.
10: The auto-important feature: there are big issues here. If I delete the contents of the textbox, the backspace key becomes the !important hotkey which is unexpected. Even worse, typing a non-printing keystroke like Delete or F8 into the box when it's empty, and then using that hotkey in the editor, will cause the editor to go into an infinite !important loop, and completely lock up Firefox. Hence I had to rewrite this entire review. :(
If there's a feature that I didn't comment on, I probably missed it. ;)
Taking all that into account, good job on this. The extra features are useful, and it's good to see that every command can be undone too! I have one suggestion: line numbers (I know, I can use my own editor... but if it's possible then it would be cool) or when getting errors, click the error go jump to that line in the code.
1. turn off styles doesn't let you work on other styles while it's off
2. i'll see about it
3. yeah that sounds better
4. i've been trying to do that by adding the menuitems, i may have to hide that menu and add another
5. it either opens the style page or opens the add new style page depending on how the style was added to stylish
6. done
7. yeah i know, but i don't know how not to remove the extra comments
8. i'll see about the extra char and made the size 25 instead of 10
9. added that to the tooltip
10. don't delete it, just disable it (i'll see about disabling certain keys) i believe np is adding line numbers to the next version of stylish, jump to errors would be nice to have though so i'll see about that also
edit: if you want to make a different icon for the manage window that would be nice :) (i have a bit of trouble noticing it with a dark background)
4: I don't know a lot about XUL, but I know you can use XUL Overlays to add items to existing elements by using merging points. Some kind of attribute like insert-after or insert-before should allow you to specify its position relative to the ID of a sibling.
5: Sounds like it might be best to have two buttons, then - dependent on whether the style has an update URL on us.o already.
7: You can use a regex pattern match such as
/\*[\s\S]*?\*/(match an opening /* and zero or more characters (as little as possible), ending with a closing */)10: Of course that's the sensible way to do it, but I was in testing mode. ;) Hopefully it won't be possible to crash FF in the future!
So, the icon? Requests welcome, but if it's going to be for one or several of the standard Stylish windows it's probably best to use the ones I already made.
7. thanks
i was thinking that new stylish icon you did for the edit dialogs and for the manage something different (no biggie though, i'll probably stick with the original)
stopped the hide toggle for preview/unpreview
added an option to change edit area font
little bug with findbox and r
renamed Toggle to Toolbar
changed Merge/!important tooltip
changed UnComment to only remove comments from start/end
removed tools menu
moved pick sites/insert color to the insert menu
blocked from using some invalid keys for auto!important
find was selecting an extra char on the end
find wasn't going grey on focus and changed not found to red
a new icon for edit dialog (thanks BoffinbraiN and for the suggestions)
:) i know just figured i'd see if you had one to use
Do you think it might be possible to just have the Toolbar extended by default instead of toggling it on/off? TIA!
@Izzy :) thanks
Stylish-Custom-0.1.0.xpi
added an option to show custom tools area by default
... and sometimes this even happens twice a day...
1: When I disable auto !important and then type a new keystroke into the box, auto !important is enabled again immediately even though the box is not ticked.
2: The uncomment button isn't behaving very well. It only removes a comment if the selection ends with a */, otherwise it only removes the first /* and nothing else. If you're using replace() with a regex, I'll have a guess and say the solution might be to make it a global find-and-replace, and also make sure there's no end-of-string ^ or $ in the regex.
3: It's nice to have an icon that stands out on the editor windows again. :) Feel free to change the icon for the Options window and the Stylish standalone window, and the extension icon, for consistency.
4: Are we still going to keep the Custom status bar menu? As I said before, all the options it provides are available in the Stylish status bar menu.
2. yea there's a $, i'll see about some different regexp
3. i like the different icons for different windows (an option to change might be a bit tricky, my js I/O needs a bit of work)
4. yep, i don't usually use the enable/disable rules (don't want it to clutter up the regular menu)