Stylish for Firefox 1.1b5

JasonBarnabe

Available here

Above of 1.1b4: Fix for "Exception calling providergetAddonByID: TypeError: style is null" error, fixed toolbar icon for Firefox 4 on Windows.

I don't expect to do any more updates other than localization, so if you see something wrong, let me know.

makondo

Thanks!

LordStriker

Oh! Nice! Thank you that you fixed the icon! Became normal like all others!

Rist

tnx, undo close tab bug gone :)

sabret00the

This is just me being picky, but is there any chance you can switch the button type menu as it's really not a button and is actually a menu. Other than that, it's perfect as per usual.

makondo

Sorry, Jason, but the thing doesn't work properly in the addons manager, at all.
Styles don't get updated (which is fine by me as i hate that anyway and would LOVE to have an option to exclude styles from AM updates/seeking for updates all together!). I just tried, out of curiosity, and it updated one style and quit on the second - nothing would happen from there on when i clicked a few more styles Update now button (didn't want to update all at once but selectively). Also, there's no any indication if an update is in progress or not - nothing happens after i clicked the Update now button (so, i still don't know if it did in fact update or not. Probably if i restart it will not show this style for update again ... guessing). Can't sort styles by Updated date - nothing happens when i click that button. If it searches for updates and suppose to update in the AM tab, i'd like it not to do the same in the sidebar when it's open and styles displayed in there as well. Royally messes it up for me. Have to restart Fx(Mf) to shake the progress bars that are stuck and 'Update is available' notice. Don't need to see this.
If missed you saying you don't care about any of this until Fx4 is final, sorry to bother.

JasonBarnabe

I'm not saying that I don't believe that you're having problems, but things work fine for me. Could it be one of your other extensions interfering with Stylish?

makondo

Define 'fine'.
It looks like absence of the update progress indication just might be a Mf bug (read in the nightlies thread bugs list something similar, will try to follow and see what's up with that).
But, can you sort styles by last updated date? 'cause i can't.
Do you think it's fine if you have progress and updates showing in the AM tab AND sidebar at the same time? I think - since the sidebar display has its own Find Updates button - it should not. If i'm looking for updates in the AM tab, it should look there only, not in the sidebar. OTOH, when i click the sidebar button, that's when it should display seeking updates/available updates in the sidebar. Makes sense (does to me)?

But most importantly, i really don't need any of this. I would like an option not to update or look for updates for style at all, anywhere (that's why i hide the sidebar update buttons in my style as they're useless to me). Another words, block the AM from looking for styles updates when i click Check for Updates (in the upper right corner toolbar button) because i'm looking for exts. updates only. I don't know if this is possible. Just asking for an option. That'd be fine by me and will eliminate all possible problems

PS. BTW, GM scripts don't look for updates.

JasonBarnabe

"Fine" means "works pretty much the same as other things in the add-ons manager".

Sorting by last update doesn't work because Stylish doesn't store the date of updates. I'll give you that much.

Updates showing in both places makes sense to me. If there's an update available, it's not dependent on the UI you used to look for it. I don't really see why you'd be using both at the same time, anyway.

If you don't want updates at all, you can modify the DB and blank out the update URLs. I don't expect most people would not want updates, so that's why there's no option for it.

I know GM scripts don't have updates through GM. I consider that a bug in GM :).

makondo

Did you unstickied this thread?

1. Updates showing in both places makes sense to me. If there's an update available, it's not dependent on the UI you used to look for it. I don't really see why you'd be using both at the same time, anyway.

2. If you don't want updates at all, you can modify the DB and blank out the update URLs. I don't expect most people would not want updates, so that's why there's no option for it.

3. I know GM scripts don't have updates through GM. I consider that a bug in GM :).

1. & 2. That's just it! I don't want it done 'both ways'. As i've explained earlier - i use the sidebar to display styles. It's always open, provides a very easy access to my styles and i like it like that.. But then i go to AM to check for my exts. updates and boom! it checks for styles updates in both places and i have to uncheck every style it (mistakenly) thinks there's an update available for just so that i can update one or two exts. that do have legit updates. I can't disable urls 'cause i use that data to update my styles (thanks to ChoGGi's S-C), smart, uh?

And that leads me to #3 - can you cook up that bug for me, please? Like, disable updates unless specifically clicked on/Check for updates? or something like that.

BTW, i say 'it (mistakenly) thinks there's an update' because it always did, we've spoke about it before. All my styles are mine (well, 2 out of 128 aren't but i don't update them either). When i post/update my styles, the site still always has Update style button! I gave up on this a long time ago and simply don't pay attention to this any more. But while it's not used to be an issue, just a silly glitch (IMO), it is now since AM sees updates (for styles that don't need it as they might have been slightly modified for my personal use and i'm not interested in 'updating' to a 'generic' version).

JasonBarnabe

The plan is to make the add-on-manager-integrated UI better until it's good enough to replace the other UI. I understand that it's lacking in many areas, but it's a work in progress. But you need to understand that you're not a typical Stylish user. Most people who use Stylish don't even write their own styles. I need to focus on things that give the most help for the most people. There are many suggestions that I hear from you and others where I understand the need for it, but I would guess that less than 1 in a 1000 users would use it.

I'm very thankful for ChoGGi for giving you and other users the kinds of power tools you need. I can get the best of both worlds by having a slimmed-down, easy to use Stylish by default, and S-C with all sorts of buttons and toggles for people that want it. So if S-C is creating a scenario where you're making changes to styles that are hooked up with updates to the site, then maybe S-C should be giving you the options you need.

Now this isn't perfect, but you could have a style like this that would hide Stylish entries on the updates panel.
@-moz-document url(about:addons) { #updates-list richlistitem[type="userstyle"] { display: none !important; } }
It'll still check for updates, and it'll still say there are available updates, but you just won't see them.

makondo

But that's not only 'not good enough' but is quite dangerous because if i don't see them, i can't uncheck them (every single one, mind you!) so that they won't update when i go to update an extension. Do you see what i mean? I click the button/Check for updates and it shows me 1 extension and a dozen of styles need an update. I have to uncheck that dozen of styles before i can update one extension. If i hide them, they will update and then ... you really don't want to know, trust me ... ...

avatards

Jason, I noticed you stopped overlaying extensions.xul in FF4 with the last beta and instead dedicate that overlay exclusively to previous versions (only overlaying about:addons in FF4). This naturally leads to Stylish UI being unavailable and, additionally, exceptions thrown in the error console when opening *extensions.xul* in FF4. In particular I'm working on an extensions manager *dialog* for FF4 and found that using extensions.xul presents some advantages over about:addons, but the Stylish category went missing lately and those errors occurred. Can you please return that functionality? While I doubt that Mozilla's decision to use the same file paths/names for entirely different chrome in FF4 was right, there seems to be an easy way to differentiate between them by application versions in order to use the right overlay files (using "application={ec8030f7-c20a-464f-9b0e-13a3a9e97384} appversion>3.6" for the FF4 overlay and style for extensions.xul).

JasonBarnabe

So extensions.xul is still there in Firefox 4, just not being used? Or are you adding it with an extension?

Drugoy

You just made Stylish's context menu have a higher z-index than the addon-bar's context men has, so actually they both open, and that's not as fast, as if you would properly fix the issue and not let the toolbar's context menu appear at all.

Drugoy

And I get a warning in the Error Console about Stylish:

While creating services from category 'profile-after-change', service for entry 'myAppHandler', contract ID '@mozilla.org/commandlinehandler/general-startup;1?type=stylish' does not implement nsIObserver.

JasonBarnabe

Which Firefox version are you on, and on what platform?

Drugoy

Latest nightly, win7x32

avatards

Jason, yes, extensions.xul is still there in 4.0, and located at the exact same global chrome path as in 3.6, but the actual chrome is, of course, completely new. "about:addons" is just a custom protocol alias for it, though there are slight differences when using it with openDialog(). Although Mozilla prefers about:addons, nothing really stops the usage of extentions.xul, and I find it slightly preferrable for the dialog. Works totally fine except overlays targeted to "about:addons" do not load into it, and Stylish, additionally, loads a 3.6 overlay which mostly fails except for the script trying to find/modify the old extension manager chrome to no avail.

Can't find any Stylish beta where extensions.xul was correctly overlaid in FF4... I was sure I had seen that... Maybe it was by mistake because of all those numerous experiments where I open the dialog in different ways... Whatever it was, it would be great if proper support for extensions.xul was there in Stylish (if you wish I can help with a patch or testing, though I don't think there should be any complications.)

JasonBarnabe

Drugoy said: Latest nightly, win7x32

With b9 on WinXP and 1.1 final, I'm not seeing the problem. I only see one menu open if I right or left click the Stylish icon in the add-ons bar.

JSax

This is just me being picky, but is there any chance you can switch the button type menu as it's really not a button and is actually a menu. Other than that, it's perfect as per usual.

I've updated to 1.1 final and, though I'm not 100% sure, I think sabret00the and I are asking for the same thing. (If not, please correct me!) Shouldn't there be a dropdown arrow next to the icon on the button since it's a menu? Besides this inconsistency, thank you for your work! It's great to have Stylish functioning 100% again.

kilroy

Hi jason, didn't wanna start a new thread, so here goes.

Using ff portable 4.0b10 & Stylish 1.1
I wanted to copy over my styles from the 3.6.x installation (non-portable).
So what do i need to do, just copying the db file would do? or do i need to do something else?

makondo

Install Stylish-Custom and Export them as single separate .css files or an xml pack. Or copy stylish.sqlite

kilroy

Aah, thanks!

Btw, i just copied over the db file (stylish.sqlite) and seems to have worked!

makondo

Sure, but S-C Export/Import makes it so damn easy! especially if you have diff. profiles and don't want all styles migrate from profile to profile.

sabret00the

This is just me being picky, but is there any chance you can switch the button type menu as it's really not a button and is actually a menu. Other than that, it's perfect as per usual.

I've updated to 1.1 final and, though I'm not 100% sure, I think sabret00the and I are asking for the same thing. (If not, please correct me!) Shouldn't there be a dropdown arrow next to the icon on the button since it's a menu? Besides this inconsistency, thank you for your work! It's great to have Stylish functioning 100% again.

Yup, we're asking for the same thing.

JasonBarnabe

1.1 is up at http://addons.mozilla.org/en-US/firefox/addon/2108/

I got the extensions.xul overlay request in as well.

I don't really like the drop marker on the icon. I guess I'd like to see what other extensions do. I found it makes it take up too much space.

WonderCsabo

Hi! Please update the Hungarian translation from Babelzilla.

JasonBarnabe

The version up there should have it as it was yesterday. Has there been another update?

WonderCsabo

Nope, somehow it showed the old strings, i reinstalled and it's fine now.

sabret00the

1.1 is up at http://addons.mozilla.org/en-US/firefox/addon/2108/

I got the extensions.xul overlay request in as well.

I don't really like the drop marker on the icon. I guess I'd like to see what other extensions do. I found it makes it take up too much space.

ABP and NoScript both use it, though in different implementations. Also space isn't something I'm worried about; I have a whole Addon Bar. I would like my buttons to remain intuitive though.